Accuracy data_time library

[Sjors Hettinga]

Dear Sir/Madam,

In the NRF date_time_ntp.c, the fraction of the NTP message is completely ignored in the line:

*date_time_ms = (int64_t)sntp_time.seconds * 1000;

Could you add the following to at least take the fraction into account.

*date_time_ms += (int64_t)(sntp_time.fraction / 1000)

 

Kind regards,

Sjors Hettinga

[Sjors Hettinga]

Another point of attention is that this implementation will hit the 2036 timing bug, as the NTP field will rollover then and there is no protection in place to deal with this:

www.lieberbiber.de/.../

[Michal]

Hello Sjors,

Thank you for reporting that, I will make a ticket internally.

Best regards,

Michal