BMA4XX driver bug

[chrisstv]

Hi 

I found another bug in the BMA4XX driver.

When using "CONFIG_BMA4XX_TEMPERATURE=y" there is a compilation failure.

Line 621 of bma4xx.c:

		rc = bma4xx_get_shift(SENSOR_CHAN_DIE_TEMP, 0, &out->shift);

 Unfortunately the first argument of the function tries to use "SENSOR_CHAN_DIE_TEMP" which is a "int16", but the first argument of the function is a "Two Word Struct" so results in a compilation failure.

Line 597 calls the function correctly:

		rc = bma4xx_get_shift((struct sensor_chan_spec){.chan_type = SENSOR_CHAN_ACCEL_XYZ,
								.chan_idx = 0},
				      header->accel_fs, &out->shift);

So I think line 621 function call needs to be changed to follow function call on Line 597 Eg:

		rc = bma4xx_get_shift((struct sensor_chan_spec){.chan_type = SENSOR_CHAN_DIE_TEMP,
								.chan_idx = 0},  0, &out->shift);

Regards

Chris

[Kenneth]

Hi,

I have forwarded the issue internally.

Thanks for reporting,
Kenneth

[chrisstv]

UPDATE...

This bug has been fixed in SDK 3.1.0.  The BMA4XX driver has been refactored.

Hope this helps anybody trying to use the BMA400.

Please note there are other issues even with the new version please refere to the link below.

https://devzone.nordicsemi.com/f/nordic-q-a/122931/failure-of-the-bma4xx-driver-to-compile

Chris