potential bug in peer_data_storage

[cp52]

Hi I think this might be a potential bug in peer_data_storage.c

ret = fds_register(fds_evt_handler); if (ret != NRF_SUCCESS) { return NRF_ERROR_INTERNAL; } ret = fds_init(); if (ret != NRF_SUCCESS) { return NRF_ERROR_NO_MEM; }

fds_register is called before fds_init(). Why is this? surely you should init before registering ?

[Sigurd]

Hi,

This is not a bug. The explanation can be found at the FDS Usage section in the infocenter:

Initialization, like all other operations in FDS that involve writing or erasing flash memory, is an asynchronous operation. Completion of the operation is reported to the application through a callback. Therefore, before initializing FDS, you must register a callback handler to handle FDS events.

[cp52]

If you have multiple users does this mean that you have to register all the call backs before initializing the module?

[Sigurd]

No, you don't have to register all the callback-handlers before initializing the FDS module. You can register more callback handlers later using the fds_register() function. The maximum number of callbacks that can be registered is defined in sdk_config.h as FDS_MAX_USERS. This is by default set to 8 users in SDK 13.