APP_CONFIG_ADV_FRAME_SPACING_MS_MIN

[frawau]

Hi,

I am trying to compile some RuuviTag application using nRF5_SDK_12.3.0_d7731ad

2 symbols are not defined, APP_CONFIG_ADV_FRAME_SPACING_MS_MIN and _ADV_FRAME_ETLM_SPACING_MS

Looking at the source, they are defined in examples/ble_peripheral/ble_app_eddystone/es_app_config.h

but used in components/libraries/eddystone/es_adv.c and components/libraries/eddystone/es_adv_timing_resolver.c

That does not seem right. Shouldn't there be a DFLT_ADV_FRAME_SPACING_MS_MIN and DFLT_ADV_FRAME_ETLM_SPACING_MS defined and used in components/libraries/eddystone? For all APP_CONFIG_* actually?

Or am I misunderstading something?

[Sigurd]

Hi,

Usually the default values for how the different drivers and libraries are configured are placed in either in sdk_config.h or in top of main.c. In most cases the only defines you find directly in the driver/library files are ~constant values you don’t want to change. For Eddystone the configurable values are placed in es_app_config.h, so you can easily configure your project in one place, instead of opening up all the different drivers and library files and change them there.