FDS delete multiple records

[xhr0428]

I call the following function to delete old FDS records before I write a new record. It works well if I have only one old record. But when there are multiple records, it stops the application. RTT viewer shows it has gone through fds_record_delete() for each record, but only the oldest one is deleted. RTT viewer also prints fatal error, but my breakpoint in app_error.c is not called.

Here is the RTT viewer printout:

 0> APP:INFO:Deleted record ID: 8 
 0> APP:INFO:Deleted record ID: 9 
 0> APP:INFO:Deleted record ID: 10 
 0> APP:INFO:Deleted record ID: 11 
 0> APP:INFO:Deleted record ID: 12 
 0> APP_ERROR:ERROR:Fatal

Here is the code:

static ret_code_t fds_test_find_and_delete (void)
{
    #define FILE_ID     0x1111
	#define REC_KEY     0x2222
	fds_record_desc_t   record_desc;
	fds_find_token_t    ftok;

	ftok.page=0;
	ftok.p_addr=NULL;
	// Loop and find records with same ID and rec key and mark them as deleted.
	while (fds_record_find(FILE_ID, REC_KEY, &record_desc, &ftok) == FDS_SUCCESS)
	{
		fds_record_delete(&record_desc);
		NRF_LOG_INFO("Deleted record ID: %d \r\n",record_desc.record_id);

	}
	// call the garbage collector to empty them
	ret_code_t ret = fds_gc();
	if (ret != FDS_SUCCESS)
	{
			return ret;
	}
	return NRF_SUCCESS;
 }

Another question is I see record ID counts up every time I write a new one. The old ID is not reused even the record is deleted. Is there an up limit for the count? What will happen if it counts to the limit?

[Petter Myhre]

You should check that the returned error code of fds_record_delete() is actually FDS_SUCCESS (0x00000000), to be sure that the call is actually accepted.

You cannot be sure that the record is deleted until the FDS_EVT_DEL_RECORD event is received.

Fatal must be printed from somewhere. Are you sure app_error_fault_handler() is not called? Try to define DEBUG, and put a breakpoint in app_error_handler()

[xhr0428]

Changing fds_record_delete(&record_desc); to uint32_t err_code = fds_record_delete(&record_desc); APP_ERROR_CHECK(err_code); triggers app_error_fault_handler() now. Error code is 8.

Another thing I noticed is if there are more than 4 records, fatal error always appears after 4 records. The first 4 records return error code 0.

[Petter Myhre]

If you look at the documentation for fds_record_delete() you can see that 0x00000008 is FDS_ERR_NO_SPACE_IN_QUEUES - If the operation queue is full.

You can try to call it at a later point in time (or wait for a FDS_EVT_DEL_RECORD event), or you can try to increase FDS_OP_QUEUE_SIZE and/or FDS_CHUNK_QUEUE_SIZE. See this for more information.

[xhr0428]

I increased FDS_OP_QUEUE_SIZE and the error is gone now. Why is this number set to 4 by default? Is there any problem setting this a large number?

Could you also answer the other question of mine? I see record ID counts up every time I write a new one. The old ID is not reused even the record is deleted. Is there an up limit for the count? What will happen if it counts to the limit?

[Petter Myhre]

Usually 4 is fine. The larger the number, the more RAM has to be reserved.

The limit is 2^32, and in practice this will never be reached.