ASERT redefined for Mesh SDK 1.0.1

[PB]

Hello,

I'm trying to update from Mesh SDK 1.0.0 to 1.0.1, I've followed http://infocenter.nordicsemi.com/topic/com.nordic.infocenter.meshsdk.v1.0.1/md_doc_getting_started_how_to_nordicSDK.html?cp=4_1_0_3_6 and have a simple application based on examples/serial from Mesh SDK modified to compile with GCC which was working for 1.0.0 but stopped after updating.

The error I'm getting after the update is the following:

In file included from ../../../../../../..//components/libraries/button/app_button.c:46:0:
../../../../../../..//components/libraries/util/nrf_assert.h:104:0: error: "ASSERT" redefined [-Werror]
 #define ASSERT(expr)                                                          \
 ^
In file included from ../../../../../../..//components/libraries/button/app_button.h:70:0,
                 from ../../../../../../..//components/libraries/button/app_button.c:42:
../../../../../../..//components/drivers_nrf/hal/nrf_gpio.h:46:0: note: this is the location of the previous definition
 #define ASSERT(...)
 ^
cc1: all warnings being treated as errors
../../../../../../..//components/toolchain/gcc/Makefile.common:272: recipe for target '_build/my_project_nrf52832/app_button.c.o' failed
make: *** [_build/my_project_nrf52832/app_button.c.o] Error 1

It seems that it's possible that the patch is causing this but I really haven't found the source. Without patching I'm getting even more errors

BTW. For non Windows users the patch command should be `patch --binary -p3 < ../nRF5_SDK_14.2.0_17b948a.patch`

Are there other things I need to consider when migrating 1.0.0 -> 1.0.1 ?

[PB]

Of course I've tried removing the includes which cause the issue but it just repeats for different sources from nRF5 SDK 14.0.2

[Hung Bui]

Could you try to remove any call to ASSERT in the nrf_gpio.h file ? We have a conflict on the way ASSERT is defined inside nrf_assert.h of the Mesh SDK or nrf_assert.h of the nRF5 SDK. 

That's why we added ASSERT(...) on top of the file.

[PB]

Hi. We have a strict "don't modify external libs" policy. Couldn't just the ASSERT in nrf_assert be added to an #ifdef when applying the nRF5_SDK_14.2.0_17b948a.patch patch?

[Hung Bui]

It could be the way. We will have much better solution for this as we planing to integrate the Mesh SDK in to nRF5 SDK in future release. For now I afraid you would need to modify the patch file to either define an #ifdef or remove assert in nrf_gpio.h to avoid the error. 

[PB]

Thank for the answer. It's great to know that integrating with nRF5 SDK is on the roadmap at some point as it greatly affects planning my work.

[Booster]

Hello Hung,

Any idea when this integrated SDK will be released?  We absolutely need this to move on with our mesh plans.

Thanks