Meaning of SAADC_CONFIG_LP_MODE. Misleading comment in nRF5_SDK_14.2.0_17b948a/config/sdk_config.h ?

[Vincent Belaïche]

Not really a question, just that I find the comment misleading. In the sdk_config.h example coming with the SDK there is this piece of code:

// <q> SAADC_CONFIG_LP_MODE - Enabling low power mode


#ifndef SAADC_CONFIG_LP_MODE
#define SAADC_CONFIG_LP_MODE 0
#endif

IMHO, comment would be improved as follows:

// <q> SAADC_CONFIG_LP_MODE - Enabling low power mode
// <0=> Disable
// <1=> Enable

#ifndef SAADC_CONFIG_LP_MODE
#define SAADC_CONFIG_LP_MODE 0
#endif

BTW, as far as I can understand, low power mode does not concern the SAADC HW but the way it interacts with PPI, TIMER, DMA, etc… for HW triggered acquisition. So if you make the acquisition in one-shot and triggered by SW, then what LP mode you set in the driver does not make any difference. Is that correct ?

[Rune Holmgren]

Hi,

Thanks for the suggestion. It has been added to the internal issue tracker of the SDK team.

You are correct, the low power mode does not affect the ADC hardware itself, but rather how the peripheral is used. If you only take a single sample it shouldn't matter as far as I can tell.

Best regards,
Rune Holmgren