GPREGRET and nrf_bootloader.c evolution proposal

[Fabien Comte]

Hello,

I propose theses evolutions in nrf_bootloader.c, it allows to use gpregret and gpregret2 for other things:

 (nrf_power_gpregret2_get() & BOOTLOADER_DFU_SKIP_CRC)

=>

((nrf_power_gpregret2_get() & 0xF8) == BOOTLOADER_DFU_GPREGRET2_MASK) && (nrf_power_gpregret2_get() & BOOTLOADER_DFU_SKIP_CRC)

and 

(nrf_power_gpregret_get() & BOOTLOADER_DFU_START)

=>

((nrf_power_gpregret_get() & 0xF8) == BOOTLOADER_DFU_GPREGRET_MASK) && (nrf_power_gpregret_get() & BOOTLOADER_DFU_START)

[Jonathan]

Hey, just for you to know, I've just bumped into a very similar case, but with a slightly different analysis, as to me, current implementation is actually breaking the behavior indicated by the comments describing those various constants. See here: https://devzone.nordicsemi.com/f/nordic-q-a/38048/bug-in-how-bootloader-treats-gpregret

Once confirmed, I hope to basically get your case from "evolution" to "bug report".

2.5.0.0

[tesc]

Hi,

Thank you for pointing back and forth between the threads, it makes it much easier for us to follow up on! I will have a look at it and follow up in the other thread.

Regards,
Terje

[Fabien Comte]

I have been promoted from evolution to bug, thank you Jonathan :-)