Error in secondary_phy check of ble_advertising_start in SDK15

[Niclas Heitz]

Hello,

in the ble_advertising_start() function of SDK15 I noticed, that the check for the secondary_phy is the same as for the primary_phy.

I assume this is a copy paste error. It is located at line 607 in the ble_advertisng.c and line 14 in this code snippet.

    // Use 1MBIT as primary phy if no phy was selected.
    if (phy_is_valid(&p_advertising->adv_modes_config.ble_adv_primary_phy))
    {
        p_advertising->adv_params.primary_phy = p_advertising->adv_modes_config.ble_adv_primary_phy;
    }
    else
    {
        p_advertising->adv_params.primary_phy = BLE_GAP_PHY_1MBPS;
    }

    if (p_advertising->adv_modes_config.ble_adv_extended_enabled)
    {
        // Use 1MBIT as secondary phy if no phy was selected.
        if (phy_is_valid(&p_advertising->adv_modes_config.ble_adv_primary_phy))
        {
            p_advertising->adv_params.secondary_phy = p_advertising->adv_modes_config.ble_adv_secondary_phy;
        }
        else
        {
            p_advertising->adv_params.secondary_phy = BLE_GAP_PHY_1MBPS;
        }
    }

Best regards,

Niclas

[tesc]

Hi,

Thank you for notifying us about this. Bug reports are always appreciated.

I agree that it looks like a bug. Our SDK team will look into it.

Regards,
Terje

[Niclas Heitz]

Hi,

this seems to still be in SDK15.2 (reported with SDK15.0).

Did the SDK team look into it?

Regards,

Niclas

[tesc]

Hi,

Unfortunately this issue has not been fixed yet.

Regards,
Terje