nRF5 SDK 15.1.0 nrf_cli.c fails to build when NRF_CLI_HISTORY 0

[tralamazza]

--- ./components/libraries/cli/nrf_cli.c	2018-08-23 07:41:32.000000000 +0200
+++ ./nRF5_SDK_15.1.0_a8c0c4d/components/libraries/cli/nrf_cli.c	2018-08-31 19:07:25.882380734 +0200
@@ -1943,7 +1943,9 @@
                 {
                     if (p_cli->p_ctx->cmd_buff_len == 0)
                     {
+#if NRF_MODULE_ENABLED(NRF_CLI_HISTORY)
                         history_mode_exit(p_cli);
+#endif
                         cursor_next_line_move(p_cli);
                     }
                     else
@@ -2072,7 +2074,9 @@
                         receive_state_change(p_cli, NRF_CLI_RECEIVE_TILDE_EXP);
                         /* fall through */
                     case 'H': /* HOME Button in VT100 mode */
+#if NRF_MODULE_ENABLED(NRF_CLI_METAKEYS)
                         cursor_home_position_move(p_cli);
+#endif
                         break;
                     case '2': /* INSERT Button in ESC[n~ mode */
                         receive_state_change(p_cli, NRF_CLI_RECEIVE_TILDE_EXP);

Including the patch I'm using.

[Kenneth]

Thanks for sharing, I have reported it internally.

Best regards,
Kenneth

[Jakub Rzeszutko]

Hi,

Regarding first part you are absulately correct.

I am not sure about second part of your patch. As meta-key I uderstand combination: ctrl + a, ctrl + w and so on. With your proposal if meta keys are not active the Home button will not work as expected.

[tralamazza]

Yeah I know, the problem lies on line 662. Maybe that ifdef should be only on NRF_CLI_METAKEYS