NRF_LOG_STR_PUSH_BUFFER_SIZE defined twice

[gnf]

In SDK 15.1.0 NRF_LOG_STR_PUSH_BUFFER_SIZE is defined twice in every sdk_config.h in the SDK. For example in the ble_app_template/pca10040/s132/config/sdk_config.h:

// <o> NRF_LOG_STR_PUSH_BUFFER_SIZE  - Size of the buffer dedicated for strings stored using @ref NRF_LOG_PUSH.
 
// <16=> 16 
// <32=> 32 
// <64=> 64 
// <128=> 128 
// <256=> 256 
// <512=> 512 
// <1024=> 1024 

#ifndef NRF_LOG_STR_PUSH_BUFFER_SIZE
#define NRF_LOG_STR_PUSH_BUFFER_SIZE 128
#endif

// <o> NRF_LOG_STR_PUSH_BUFFER_SIZE  - Size of the buffer dedicated for strings stored using @ref NRF_LOG_PUSH.
 
// <16=> 16 
// <32=> 32 
// <64=> 64 
// <128=> 128 
// <256=> 256 
// <512=> 512 
// <1024=> 1024 

#ifndef NRF_LOG_STR_PUSH_BUFFER_SIZE
#define NRF_LOG_STR_PUSH_BUFFER_SIZE 128
#endif

[tesc]

Hi,

Thank you for notifying us about this bug. It is highly appreciated! I have registered it in our internal tracker. Hopefully we can fix it before too long.

Regards,
Terje

[Christian Waldmann]

Now the section isn't present anymore in the released nRF5_SDK_15.2.0_9412b96

When sdding it once, it compiles

[tesc]

Hi,

I am afraid nRF5 SDK v15.2.0 was too far in the release pipeline for going back to change this before release. (This is not really a critical bug, although it may be a bit annoying.) Hopefully we will look into it shortly and fix it for future releases.

Regards,
Terje

[tesc]

Hi,

We have had some issues with some sections of the sdk_config.h file missing in some examples (but still it was present in others). This is a known issue, and is probably the reason why you did not find it in the example that you were looking at. (It is not limited to NRF_LOG_STR_PUSH_BUFFER_SIZE.)

Regards,
Terje

[gnf]

Ok, now I see the last post was an answer to Christian. Anyway, to clarify even more, the problem I am talking about is that the section is defined twice, one after each other.

I attach two screenshots to explain this in detail.

Keil Configuration Wizard:

Here in a search in Eclipse. To me it seems a lot of sdk_config.h files suffer from this:

[tesc]

Hi,

Thank you for the clarification.

Yes, both issues are reported in our internal issue tracker as separate bugs.

It currently is not entirely clear what posts are replies to what other posts here on DevZone, but the post about "sections of the sdk_config.h file missing" was to Christian Waldmann and the post about "too late in the release pipeline" was to you (gnf).

Regards,
Terje

[Christian Waldmann]

The missing entry in my project is based on the fact that I am trying to upgrade an existing project from SDK 5.0 to SDK 5.2. So in the already existing sdk_config.h in my project the entry is missing.

Regarding the many changes in the source tree, this way of porting is hard to to.

I think I will try to integrate my solution again in the example from SDK 5.2 that was my starting point in the SDK 5.0.

Happy coding

Chris