Bug in ble_advertising.c, secondary phy for extended advertising packet, SDK 15+

[Cyril]

Hello,

I think there is an error in ble_advertising.c (SDK 15+). 

Line 608, the code is trying to set the secondary phy but checks if the primary phy is valid (ble_adv_primary_phy). 

 
    if (p_advertising->adv_modes_config.ble_adv_extended_enabled)
    {
        // Use 1MBIT as secondary phy if no phy was selected.
        if (phy_is_valid(&p_advertising->adv_modes_config.ble_adv_primary_phy)) // <== Check secondary phy here
        {
            p_advertising->adv_params.secondary_phy = p_advertising->adv_modes_config.ble_adv_secondary_phy;
        }
        else
        {
            p_advertising->adv_params.secondary_phy = BLE_GAP_PHY_1MBPS;
        }
    }

Best,
Cyril

[Vidar Berg]

Hello Cyril,

Thanks for letting us know. This could potentially override the secondary phy setting if the primary phy wasn't set. I have reported it internally. 

[kathleenlai]

Hi Vidar Berg,

Has the bug solved? 

I changed it to ble_adv_secondary_phy but it return me fatal error.

Thank you .

Regards,

Kathleen

[Vidar Berg]

Hi Kathleen,

It has not been fixed, but it's only relevant if you have forgotten to specify PHY on the primary channel. I think the fatal error is most likely caused by something else. If you use Segger embedded studio, select "Debug" target from the dropdown menu in the top left corner before building. It will give you a more detailed crashlog.  

Regards,

Vidar

[kathleenlai]

Hi Vidar Berg ,

thank you for replying me.

I at first using nRF52840 PDK with pca10056 v0.9.2 using SDK 15.3 to do CODED PHY advertising, I found out the debug was smoothed and never shown any error. The sniffer anyhow only show me 1 advertising packet while the debug terminal info give "fast mode advertising". I changed to nRF52840 DK board with the same code running , it works fine. I  also tried change the .primary_phy to secondary_phy in the bug line, it gives fatal error.

1. Does the bug affected or simply the PDK is different with DK ?

2. Besides, the SDK 15.3 support S140 v6.1.1 means if I run the example code to my PDK board, it will auto call the S140 v6.1.1 protocol?

Thank you once again.

Regards,

Kathleen

[Vidar Berg]

Hi Kathleen, 

You can try the example I uploaded here: https://devzone.nordicsemi.com/f/nordic-q-a/40476/unable-to-convert-to-long-range-after-looking-at-umpteen-examples--. It has CODED PHY enabled on both the primary and the secondary channel. 

1. Yes, the preview DK is different. It has IC engineering rev. A of the nrf52840 that has erratas that may impact the radio performance. It's recommended to use the DK now. 

2. Yes, v6.1.1 is used with SDK 15.3.0 examples. 

Regards,

Vidar