Processing RSSI Value

[Kebab]

At the moment I am collecting 64 RSSI values into an array and want to calculate the average and variance of them. I have managed to calculate the average by adding up the values during collection but trying to find the deviation after the collection phase is not working. It seems as though the RSSI values have just been forgotten and a random variance value is spat out. I have attached the code below and highlighted where the code seems to be going wrong. Any observations or recommendations would be much appreciated! Apologies in advance for the novice level code. Thanks!

[hmolesworth]

Assuming stdcount is initialised to 0 every time (not shown in code), the last occurring RSSICount++ should actually be RSSICount = 0;

[Kebab]

Yes it was initialized to 0. Is that just a good practice thing? It didn't seem to change the outcome of the program.

[hmolesworth]

No the first time, assuming it is in the zerovars section which would be the default, but since it is not created within the function it will retain its previous value on the next calculation (if any), which of course would cause an error. Ideally istdcount = 0; should be added at the end of the calculation ready for the next time, or better at the beginning of that calculation loop.

[Einar Thorsrud]

Hi,

There is clearly a problem with your RSSI array. It is not static, so it is allocated on stack. Therefore it is expected that it is corrupted.

PS: Please use Insert -> Insert Code instead of an image when posting code, as that makes it easier to read and search in it.

[Kebab]

Ah thank you! Making it static fixed the issue.

I'll take note of that formatting for future reference too, thanks for the heads up.