Error adding USBD project

[shenwrt]

• I want to add USBD function in other projects, but there is an error:“..\..\..\..\..\..\components\libraries\usbd\class\hid\generic\app_usbd_hid_generic.c(257): error:  #20: identifier "ret" is undefined”

• How to modify？ Thank you all

• This is my project fileble_app_hids_keyboard.rar

[shenwrt]

• Normal after deleting critical Macro：

// CRITICAL_REGION_ENTER();
ret_code_t ret = app_usbd_ep_transfer(ep_addr, &transfer);
if (ret == NRF_SUCCESS)
{
app_usbd_hid_state_flag_set(&p_generic_ctx->hid_ctx,
APP_USBD_HID_STATE_FLAG_TRANS_IN_PROGRESS);
}
// CRITICAL_REGION_EXIT();

return ret;

[Turbo J]

Those CRITICAL_REGION macros contain a "{" and a "}" character each, thus "ret" is outside scope at the return statement.

Fix is really simple, just declare it early:

ret_code_t ret;

CRITICAL_REGION_ENTER();

ret = app_usbd_ep_transfer(ep_addr, &transfer);
if (ret == NRF_SUCCESS)
{
app_usbd_hid_state_flag_set(&p_generic_ctx->hid_ctx,
APP_USBD_HID_STATE_FLAG_TRANS_IN_PROGRESS);
}

CRITICAL_REGION_EXIT();

return ret;

[shenwrt]

OK, thank you. But the original official example is normal here?

[Sigurd]

shenwrt said:

But the original official example is normal here?

Yes, that is because the CRITICAL_REGION macros is only using "{" and a "}" character when we have SOFTDEVICE_PRESENT defined.

So this is a bug in app_usbd_hid_generic.c, app_usbd_hid_generic_idle_report_set() function, I will report it internally.