pc-ble-driver suffix is messed up when compiling 4.1.1

[jpo38]

I compiled 4.0.0 in the past and the generated libraries were named "pc_ble_driver_shared_sd_api_vX.dll".

Now I compiled 4.1.1 and the libraries are named "nrf-ble-driver-sd_api_vX-mt-gd-0_0_0.dll".

Have I done something wrong or are the CMake scripts broken? I compiled sources downloaded through "source code" link provided in https://github.com/NordicSemiconductor/pc-ble-driver/releases.

[Jørgen Holmefjord]

Hi,

The renaming of the project was mentioned in release notes for v4.1.0. Is this causing any issues?

Best regards,
Jørgen

[jpo38]

Hello again ;-)

Project name is not an issue. But binaries being tagged 0_0_0 instead of 4_1_1 is an issue.

Jean

[Jørgen Holmefjord]

It looks like these should be set by the variables ${PROJECT_VERSION_MAJOR}, ${PROJECT_VERSION_MINOR}, and ${PROJECT_VERSION_PATCH}.

I will check with the developer if you are supposed to set these manually, or if something is missing from the script.

[jpo38]

Looks like adding -DNRF_BLE_DRIVER_VERSION=4.1.1 on CMake command line is the way to fix that. But it should not be required when building a release picked up from the release branch, it should be automatic/frozen.

[Jørgen Holmefjord]

This is the feedback I got from the developers:

If you are using vcpkg, the version number will be set and associated with checksum/tag of the source code: https://github.com/NordicPlayground/vcpkg/blob/master/ports/nrf-ble-driver/portfile.cmake .

When downloading the precompiled releases, the version number is set.

[jpo38]

OK, that makes sense. Now when you build from sources, would be nice to have documentation mention that NRF_BLE_DRIVER_VERSION should be set. Or, eaxh branch should have it be fixed, to prevent builds generating 0.0.0 tagged files.