make DIODE_FWD_VOLT_DROP_MILLIVOLTS configurable/overwritable

[yuecelm]

DIODE_FWD_VOLT_DROP_MILLIVOLTS is normally depending on how the reverse current protection is implemented in hardware. the current value of 270mV is adapted to the used diode on pca10040. but its also possible the implement the reverse current protection with a transistor and the voltage drop would be 0 mV in my case. is it possible to make DIODE_FWD_VOLT_DROP_MILLIVOLTS configurable/overwritable in components/ble/ble_services/eddystone/es_battery_voltage_saadc.c?

[Simonr]

Hi Mustafa

You can change the value of DIODE_FWD_VOLT_DROP_MILLIVOLTS to 0 in your project. But you'll have to remember to set it back to 270 if you're testing it on the DK.

Best regards,

Simon

[yuecelm]

currently you would now change a file in the SDK in order to change the value, why not doing something like this?

#ifndef DIODE_FWD_VOLT_DROP_MILLIVOLTS
#define DIODE_FWD_VOLT_DROP_MILLIVOLTS 270
#endif

this way you can change the value over a compile flag without overwriting a SDK file and you can set the right value per hardware platform...