bugfix requests: set tx power in tlm frame results in app error with eddystone configuration service

[yuecelm]

set the tx power of a tlm frame with the eddystone configuration service will result currently in an app error. call path is es_gatts_write_handle_unlocked_write -> es_slot_radio_tx_pwr_set -> set_ranging_data_for_slot. I propose the following change in components/ble/ble_services/eddystone/es_slot.c under function set_ranging_data_for_slot:

    es_adv_frame_t * frame = &m_reg.slots[slot_no].adv_frame;
    switch (frame->type)
    {
        case ES_FRAME_TYPE_UID:
        {
            es_uid_frame_t * uid = &frame->frame.uid;
            uid->ranging_data    = ranging_data;
            break;
        }

        case ES_FRAME_TYPE_URL:
        {
            es_url_frame_t * url = &frame->frame.url;
            url->ranging_data    = ranging_data;
            break;
        }

        case ES_FRAME_TYPE_EID:
        {
            es_eid_frame_t * eid = &frame->frame.eid;
            eid->ranging_data    = ranging_data;
            break;
        }

        case ES_FRAME_TYPE_TLM:
-           APP_ERROR_CHECK(NRF_ERROR_INVALID_PARAM);
            break;
    }

[Susheel Nuguru]

Hi Mustafa,

I checked es_slot.c in SDK15.3 and the code you proposed is exactly the same as in official SDK. What change did you suggest?

[yuecelm]

remove "APP_ERROR_CHECK(NRF_ERROR_INVALID_PARAM);", there is a minus sign at the beginning of the line for deleting the line

[Susheel Nuguru]

Did you realize that it was a part of a diff code snippet. So I missed seeing the minus sign, sorry about that.

Your suggestion is valid for the feature extension you are doing, I created an internal ticket for the team requesting it to include in our repo. For your reference, the internal ticket number is NRFFOETT-2339.