notification_timeout_handler no longer working when NRF_SDH_BLE_OBSERVERS() is used (SDK v15)

Question

Hi in my original code when notifications is turned on for custom characteristic the characteristic value would increment every second. However after I add NRF_SDH_BLE_OBSERVERS() so I can add multiple custom services, I notice the characteristic value no longer increments every second when notifications is turned on. 
 If I switch back to NRF_SDH_BLE_OBSERVER() and turn on notifications the characteristic value increments every second again. 
 /*
#define BLE_CUS_DEF(_name) \
static ble_cus_t _name; \
NRF_SDH_BLE_OBSERVER(_name ## _obs, \
 BLE_HRS_BLE_OBSERVER_PRIO, \
 ble_cus_on_ble_evt, &_name)
 */

#define BLE_CUS_DEF(_name) \
static ble_cus_t _name; 
#define BLE_CUS_DEF2(_name2) \
static ble_cus_t _name2; //\
#define ble_cus_t* cus_array[] = {&_name, &_name2}; \
NRF_SDH_BLE_OBSERVERS(_name ## _obs, \
 BLE_HRS_BLE_OBSERVER_PRIO, \
 ble_cus_on_ble_evt, cus_array, 2) 
 In the code, 'notification_timeout_handler' is called when the repeated app timer 'm_notification_timer_id' expires. The 'notification_timeout_handler' increments the value of integer variable 'm_custom_value' each time the app_timer event handler is called. 
 
APP_TIMER_DEF(m_notification_timer_id);

static uint8_t m_custom_value = 0;
static uint8_t notif_bool = 0;


static void notification_timeout_handler(void * p_context)
{
 UNUSED_PARAMETER(p_context);
 ret_code_t err_code;
 
 // Increment the value of m_custom_value before nortifing it.
 m_custom_value++;

 if(notif_bool == 1){
 err_code = ble_cus_custom_value_update(&m_cus, m_custom_value);
 //APP_ERROR_CHECK(err_code);
 }
}

static void timers_init(void)
{
 // Initialize timer module.
 ret_code_t err_code = app_timer_init();
 APP_ERROR_CHECK(err_code);

 // Create timers.
 err_code = app_timer_create(&m_notification_timer_id, APP_TIMER_MODE_REPEATED, notification_timeout_handler);
 APP_ERROR_CHECK(err_code);

}

tatic void on_cus_evt(ble_cus_t * p_cus_service,
 ble_cus_evt_t * p_evt)
{
 ret_code_t err_code;
 
 switch(p_evt->evt_type)
 {
 case BLE_CUS_EVT_NOTIFICATION_ENABLED:
 
 notif_bool = 1;
 break;

 case BLE_CUS_EVT_NOTIFICATION_DISABLED:

 break;
}

 
 I also attached the project files below. 
 multiple_cus_app_timer.zip 
 Why does calling NRF_SDH_BLE_OBSERVERS() to register multiple custom services cause the event handler call from the repeated app timer to not work? Is there a way to fix this if I want to have multiple custom services and the app_timer event handler?

Einar Thorsrud · Accepted Answer

Hi, 
 I had to adjust your sdk_config.h file and SES project settings to make the project run (ble_cus.c was not added to the project, NRF_SDH_BLE_VS_UUID_COUNT in sdk_config.h was 0 but should be 1, and adjusting that requires the RAM start address and size to be adjusted). Once I did I reproduced the error. Then I looked at your code, and the error is in fact quite obvious. 
 Looking at the first code snippet in your last post (the one with problems), there is no wonder things are not working. The only two lines that are actually relevant (meaning is ever executed) is 9-10, so the only thing you do is make a static variable _name. You ever call NRF_SDH_BLE_OBSERVERS(), since you never call BLE_CUS_DEF2(). And in fact that would not have worked either since you have commented out the backslash on line 12 (still in the first code snippet. 
 So to break it down, the actual definition of BLE_CUS_DEF() in your code is: 
 #define BLE_CUS_DEF(_name) \
static ble_cus_t _name; 
 And the actual definition of BLE_CUS_DEF2() is: 
 #define BLE_CUS_DEF2(_name2) \
static ble_cus_t _name2; 
 So you will never actually call NRF_SDH_BLE_OBSERVERS() this way. I suggest you copy the approach from the other SDK service implementations if you want a macro to make multiple instances (you can look at line 98-102 in <SDK15.3>\components\ble\ble_services\ble_dis_c\ble_dis_c.h, or any of the other services in the SDK).

notification_timeout_handler no longer working when NRF_SDH_BLE_OBSERVERS() is used (SDK v15)

Top Replies