Extend Serial DFU

[schef]

Hi,

as i mention in https://devzone.nordicsemi.com/f/nordic-q-a/44924/dfu-serial-failed i have f ramming error now and then when i do DFU over serial.

My idea was to write some code in nrf_dfu_serial_uart.c to make a better validation of data that was received, request a replay if the data was corrupted or send CRC back to the master and when the data is OK send it to the application. So in the uart_event_handler i would collect data and when the data is OK i would pass it to on_rx_complete.

That works fine. The issue i am having is:

• on_rx_complete expects nrf_dfu_serial_t *p_transport which i don't have any more if i collect and validate the data in another part of the code. A workaround would be to save the last context in a global variable and send it to the function when the data is ready. Is this OK?
• if the data is corrupted i would want to report this to the master but i could not send the message from uart_event_handler, i got error 17 from nrf_drv_uart_tx
• I tried to implement UART driver with FIFO but then i have no UART context to send to on_rx_complete and nrf_dfu_serial_on_packet_received
• if i would want to report the error from the main context i don't know where the application is at the point of the UART interrupt to send the message
• if i use nrf_drv_uart_tx with buffer bigger then 1 and don't use nrf_delay_ms in between i get wrong bytes on the other end.

Do you have any suggestions?

I'm using nrf52840 with sdk15.2 and uart without HWFC.

Thanks

.

[schef]

I found a possible solution. I added app_timer and was feeding all TX bytes to a buffer and in a separate callback which was triggered from timer emptying the same buffer using nrf_drv_uart_tx.

[Vidar Berg]

Thanks for the update. It sounds like you may have found a solution to this. I also think the Libuarte - advanced UARTE driver might be an alternative to consider. I haven't tried it with the bootloader, but you can use larger DMA buffers if it works.

[schef]

Yes, this part works. But i have another issue. I was using pca10056_uart_debug and FOTA successfuly passed but the main application hangs on boot (i just got few lines from the main application in log). But when i use pca10056_ble_uart_debug the bootloader is to big and it didn't fit into the FLASH. So i turned off the LOG and then i could compile and flash the bootloader and the main application works. But i'm not happy that i have no logs. So i tried to turn off pca10056_ble_uart_debug becase i don't use ble in this project so i had to remove nrf_dfu_ble.c and nrf_dfu_settings_svci.c and set NRF_DFU_TRANSPORT_BLE to 0 i sdk_config.h but then i got the same result as with pca10056_uart_debug, the main application after few lines hangs. Any suggestions?

[schef]

Could it be connected with devzone.nordicsemi.com/.../214427

[Vidar Berg]

The issue you linked to doesn't make sense to me, I think it has to be something else. Could you try to attach the debugger and debug the app after DFU to find out where it hangs?

[schef]

So i guess it hangs here:

Program received signal SIGTRAP, Trace/breakpoint trap.
0x000ea3f6 in ?? ()
(gdb) bt
#0  0x000ea3f6 in ?? ()
#1  <signal handler called>
#2  0x0003ec6a in svci_nrf_dfu_set_adv_name_svci_async_init (p_async=0x2000ba34 <nrf_dfu_set_adv_name_svci_async_def>) at ../../../../submodules/firmware_nrf52_sdk_15_2/src/nRF5_SDK_15.2.0_9412b96/components/ble/ble_services/ble_dfu/ble_dfu_unbonded.c:61
#3  0x0003ec7e in nrf_dfu_set_adv_name_svci_async_init (p_async=0x2000ba34 <nrf_dfu_set_adv_name_svci_async_def>) at ../../../../submodules/firmware_nrf52_sdk_15_2/src/nRF5_SDK_15.2.0_9412b96/components/ble/ble_services/ble_dfu/ble_dfu_unbonded.c:61
#4  0x0003ec92 in nrf_dfu_set_adv_name_init () at ../../../../submodules/firmware_nrf52_sdk_15_2/src/nRF5_SDK_15.2.0_9412b96/components/ble/ble_services/ble_dfu/ble_dfu_unbonded.c:61
#5  0x0003ee22 in ble_dfu_buttonless_async_svci_init () at ../../../../submodules/firmware_nrf52_sdk_15_2/src/nRF5_SDK_15.2.0_9412b96/components/ble/ble_services/ble_dfu/ble_dfu_unbonded.c:151
#6  0x0003c016 in nordic_ble_dfu_buttonless_async_svci_init () at ../../../../submodules/firmware_nrf52_sdk_15_2_extended/src/nordic_ble_dfu.c:25
#7  0x000310cc in BleCommon::BleCommon (this=0x20011628) at ../../../../submodules/firmware_nrf52_lib_ble/src/ble_common/ble_common.cpp:28
#8  0x0003108c in BleCommon::getInstance () at ../../../../submodules/firmware_nrf52_lib_ble/src/ble_common/ble_common.cpp:16
#9  0x0002d478 in main () at ../../../main.cpp:52
(gdb) 

IIt looks like NRF_SVCI_ASYNC_FUNC_DEFINE(NRF_DFU_SVCI_SET_ADV_NAME, nrf_dfu_set_adv_name, nrf_dfu_adv_name_t) never returned.

[Vidar Berg]

nrf_dfu_set_adv_name_init() should only be called if the bootloader supports DFU over BLE. For serial DFU you don't have to set up the SVC interface with the Bootloader.  

[schef]

This was it. Thnx.