Receiving data from UART via a peripheral device

[Thomas]

Hi

I am working with a Nordic nrf52840dk using segge and sdk 16.

I am using the nordic UART example in examples/peripheral/uart.

The issue I am having is that my data being sent to this device can not be read from the nordic board.

Below is an example of the code going into my Putty terminal from my UART peripheral device.

1,1183,1,1169
1,1183,1,1169
1,1183,1,1169
1,1183,1,1169
1,1183,1,1169
1,1183,1,1169

This device has 4 wire connections RX,TX,CTS and RTS. My connections are listed below:

Note this is the default.

#define RX_PIN_NUMBER  8
#define TX_PIN_NUMBER  6
#define CTS_PIN_NUMBER 7
#define RTS_PIN_NUMBER 5

The first thing i tried was running the code with no change to see if app_uart_get(&cr) would pull this data. Unfortunately it did not. It does however, pull data that i type into the terminal.

What I want to do is to take this data from the UART(Sensor data) and store it as a variable for handling later on.

I which to know how I can pull this data from the serial connection.

Side note when the device (UART) is plugged in printing from putty does not run. If I unplug the device then printing works fine.  Below is my main code (from example).

int main(void)
{
    uint32_t err_code;

    bsp_board_init(BSP_INIT_LEDS);

    const app_uart_comm_params_t comm_params =
      {
          RX_PIN_NUMBER,
          TX_PIN_NUMBER,
          RTS_PIN_NUMBER,
          CTS_PIN_NUMBER,
          UART_HWFC,
          false,
#if defined (UARTE_PRESENT)
          NRF_UARTE_BAUDRATE_115200
#else
          NRF_UARTE_BAUDRATE_115200
#endif
/*
#if defined (UART_PRESENT)
          NRF_UART_BAUDRATE_115200
#else
          NRF_UARTE_BAUDRATE_115200
#endif
*/
      };

    APP_UART_FIFO_INIT(&comm_params,
                         UART_RX_BUF_SIZE,
                         UART_TX_BUF_SIZE,
                         uart_error_handle,
                         APP_IRQ_PRIORITY_HIGH,
                         //APP_IRQ_PRIORITY_LOWEST,
                         err_code);

    APP_ERROR_CHECK(err_code);

#ifndef ENABLE_LOOPBACK_TEST
    printf("\r\nUART example started.\r\n");

    while (true)
    {
        uint8_t cr;
        while (app_uart_get(&cr) != NRF_SUCCESS);
        while (app_uart_put(cr) != NRF_SUCCESS);

        if (cr == 'q' || cr == 'Q')
        {
            printf(" \r\nExit!\r\n");

            while (true)
            {
                // Do nothing.
            }
        }
    }
#else

    // This part of the example is just for testing the loopback .
    while (true)
    {
        uart_loopback_test();
    }
#endif
}

[Einar Thorsrud]

Hi,

It is not entirely clear to me, but the serial terminal on the PC is via the onboard debugger, right (USB connector on the left of the board)? If you are using that (or have the debugger enabled in general so that IF OFF is not asserted, then you should use different pins for the external UART device. In other words, connect the UART pins between the nRF and another device to some available GPIO pins, and update the pin number defines.

[Thomas]

Thanks for your response, I am using the onboard usb connector (the one in the top-middle of the board). This is where my putty serial terminal connects to. Jlink CDC UART PORT(COM5)

I have tried redefining the pinouts to:

#define RX_PIN_NUMBER  NRF_GPIO_PIN_MAP(0,3)//8
#define TX_PIN_NUMBER  NRF_GPIO_PIN_MAP(0,28)//6
#define CTS_PIN_NUMBER NRF_GPIO_PIN_MAP(0,4)//7
#define RTS_PIN_NUMBER NRF_GPIO_PIN_MAP(0,29)//5

I have then connected my device to those pinout.

However, I now no longer see that information (from the uart device) to putty, nor can I use a printf command and see the result.

When I  run this through the dubugger after running the APP_UART_FIFO_INIT and checking the error code it goes to NRF_BREAKPOINT_COND;

I then get this in the call stack area of the debugger.

What other details do you need to help resolve this issue?

[Thomas]

Yes I am using SES. I have tried changing the debugger but, it still did not solve the issue.

[Thomas]

So I have gotten my hands on a logic analyser and this is what I am sending to the UART pins

And this is  the Ascii Data as well:

What do you think I should check next to resolve the issue?

[Einar Thorsrud]

Hi,

We know the data is there on the input, so the question is why you do not see it from your application. Just to recap. You wrote some replies back that when stepping through the code you see that "it holds on" "while (app_uart_get(&cr) != NRF_SUCCESS);". I interpreted that to mean that once that loop enters, it will just stay there (calling app_uart_get() repeatedly since it doe snot return NRF_SUCCESS). But later you write that "The debugger never seems to execute the app_uart_get line, therefore, I cant see the error code", so that is not consistent. Can you elaborate on what you are seeing? Knowing any error return valued would be useful. Also, if you could upload your complete code that would make it easier to see what you are doing.

Also, can you make sure to set UART_HWFC to APP_UART_FLOW_CONTROL_ENABLED? (make sure that it is not changed later, as it is set in the example application based on weather ENABLE_LOOPBACK_TEST is enabled or not).

[Einar Thorsrud]

Hi Thomas,

I did not look much into the pins you used, but hey are not the best. You should pick unused pins for this test. So, for instance, pin GPIO P0.26-P0.29 are good.

Also, I just set up a simple test on my side, having a UART input with no flow control to minimize the complexity, and modifying the example minimally (or rather remove as much as possible).

Can you see if this works for you? Note that you need to change the pin to whatever you use. And if your sensor needs flow control, add that (or just hardwire it).

With this example, you can set a breakpoint on line 129 and see that it will end up there again if you continue, and you can inspect rx_buf to see the received data.

Fullscreen main.c Download

/**
 * Copyright (c) 2014 - 2019, Nordic Semiconductor ASA
 *
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification,
 * are permitted provided that the following conditions are met:
 *
 * 1. Redistributions of source code must retain the above copyright notice, this
 *    list of conditions and the following disclaimer.
 *
 * 2. Redistributions in binary form, except as embedded into a Nordic
 *    Semiconductor ASA integrated circuit in a product or a software update for
 *    such product, must reproduce the above copyright notice, this list of
 *    conditions and the following disclaimer in the documentation and/or other
 *    materials provided with the distribution.
 *
 * 3. Neither the name of Nordic Semiconductor ASA nor the names of its
 *    contributors may be used to endorse or promote products derived from this
 *    software without specific prior written permission.
 *
 * 4. This software, with or without modification, must only be used with a
 *    Nordic Semiconductor ASA integrated circuit.
 *
 * 5. Any software provided in binary form under this license must not be reverse
 *    engineered, decompiled, modified and/or disassembled.
 *
 * THIS SOFTWARE IS PROVIDED BY NORDIC SEMICONDUCTOR ASA "AS IS" AND ANY EXPRESS
 * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 * OF MERCHANTABILITY, NONINFRINGEMENT, AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED. IN NO EVENT SHALL NORDIC SEMICONDUCTOR ASA OR CONTRIBUTORS BE
 * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
 * GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
 * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 */
/** @file
 * @defgroup uart_example_main main.c
 * @{
 * @ingroup uart_example
 * @brief UART Example Application main file.
 *
 * This file contains the source code for a sample application using UART.
 *
 */

#include <stdbool.h>
#include <stdint.h>
#include <stdio.h>
#include "app_uart.h"
#include "app_error.h"
#include "nrf_delay.h"
#include "nrf.h"
#include "bsp.h"
#if defined (UART_PRESENT)
#include "nrf_uart.h"
#endif
#if defined (UARTE_PRESENT)
#include "nrf_uarte.h"
#endif



#define MAX_TEST_DATA_BYTES     (15U)                /**< max number of test bytes to be used for tx and rx. */
#define UART_TX_BUF_SIZE 256                         /**< UART TX buffer size. */
#define UART_RX_BUF_SIZE 256                         /**< UART RX buffer size. */

static char rx_buf[1024];


void uart_error_handle(app_uart_evt_t * p_event)
{
    if (p_event->evt_type == APP_UART_COMMUNICATION_ERROR)
    {
        APP_ERROR_HANDLER(p_event->data.error_communication);
    }
    else if (p_event->evt_type == APP_UART_FIFO_ERROR)
    {
        APP_ERROR_HANDLER(p_event->data.error_code);
    }
}


#define UART_HWFC APP_UART_FLOW_CONTROL_ENABLED


/**
 * @brief Function for main application entry.
 */
int main(void)
{
    uint32_t err_code;

    bsp_board_init(BSP_INIT_LEDS);

    const app_uart_comm_params_t comm_params =
      {
          RX_PIN_NUMBER,
          TX_PIN_NUMBER,
          RTS_PIN_NUMBER,
          CTS_PIN_NUMBER,
          UART_HWFC,
          false,
#if defined (UART_PRESENT)
          NRF_UART_BAUDRATE_115200
#else
          NRF_UARTE_BAUDRATE_115200
#endif
      };

    APP_UART_FIFO_INIT(&comm_params,
                         UART_RX_BUF_SIZE,
                         UART_TX_BUF_SIZE,
                         uart_error_handle,
                         APP_IRQ_PRIORITY_LOWEST,
                         err_code);

    APP_ERROR_CHECK(err_code);

    printf("\r\nUART example started.\r\n");

    int pos = 0;

    while (true)
    {
        while (app_uart_get(&rx_buf[pos]) != NRF_SUCCESS);
        pos++;
    }

}


/** @} */

[Thomas]

Sorry It does'nt execute the line app_uart_get(&cr) it goes to it once. I then use the debugger to step over the code an nothing happens. Also loopback test is disabled.

Here is all my code:

/**
 * Copyright (c) 2014 - 2019, Nordic Semiconductor ASA
 *
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification,
 * are permitted provided that the following conditions are met:
 *
 * 1. Redistributions of source code must retain the above copyright notice, this
 *    list of conditions and the following disclaimer.
 *
 * 2. Redistributions in binary form, except as embedded into a Nordic
 *    Semiconductor ASA integrated circuit in a product or a software update for
 *    such product, must reproduce the above copyright notice, this list of
 *    conditions and the following disclaimer in the documentation and/or other
 *    materials provided with the distribution.
 *
 * 3. Neither the name of Nordic Semiconductor ASA nor the names of its
 *    contributors may be used to endorse or promote products derived from this
 *    software without specific prior written permission.
 *
 * 4. This software, with or without modification, must only be used with a
 *    Nordic Semiconductor ASA integrated circuit.
 *
 * 5. Any software provided in binary form under this license must not be reverse
 *    engineered, decompiled, modified and/or disassembled.
 *
 * THIS SOFTWARE IS PROVIDED BY NORDIC SEMICONDUCTOR ASA "AS IS" AND ANY EXPRESS
 * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 * OF MERCHANTABILITY, NONINFRINGEMENT, AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED. IN NO EVENT SHALL NORDIC SEMICONDUCTOR ASA OR CONTRIBUTORS BE
 * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
 * GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
 * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 */
/** @file
 * @defgroup uart_example_main main.c
 * @{
 * @ingroup uart_example
 * @brief UART Example Application main file.
 *
 * This file contains the source code for a sample application using UART.
 *
 */

#include <stdbool.h>
#include <stdint.h>
#include <stdio.h>
#include "app_uart.h"
#include "app_error.h"
#include "nrf_delay.h"
#include "nrf.h"
#include "bsp.h"
#if defined (UART_PRESENT)
#include "nrf_uart.h"
#endif
#if defined (UARTE_PRESENT)
#include "nrf_uarte.h"
#endif


//#define ENABLE_LOOPBACK_TEST  /**< if defined, then this example will be a loopback test, which means that TX should be connected to RX to get data loopback. */

#define MAX_TEST_DATA_BYTES     (15U)                /**< max number of test bytes to be used for tx and rx. */
#define UART_TX_BUF_SIZE 256                         /**< UART TX buffer size. 256*/
#define UART_RX_BUF_SIZE 256                         /**< UART RX buffer size. 256*/

void uart_error_handle(app_uart_evt_t * p_event)
{
    if (p_event->evt_type == APP_UART_COMMUNICATION_ERROR)
    {
        APP_ERROR_HANDLER(p_event->data.error_communication);
    }
    else if (p_event->evt_type == APP_UART_FIFO_ERROR)
    {
        APP_ERROR_HANDLER(p_event->data.error_code);
    }
}


#ifdef ENABLE_LOOPBACK_TEST
/* Use flow control in loopback test. */
#define UART_HWFC APP_UART_FLOW_CONTROL_ENABLED

/** @brief Function for setting the @ref ERROR_PIN high, and then enter an infinite loop.
 */
static void show_error(void)
{

    bsp_board_leds_on();
    while (true)
    {
        // Do nothing.
    }
}


/** @brief Function for testing UART loop back.
 *  @details Transmitts one character at a time to check if the data received from the loopback is same as the transmitted data.
 *  @note  @ref TX_PIN_NUMBER must be connected to @ref RX_PIN_NUMBER)
 */
static void uart_loopback_test()
{
    uint8_t * tx_data = (uint8_t *)("\r\nLOOPBACK_TEST\r\n");
    uint8_t   rx_data;

    // Start sending one byte and see if you get the same
    for (uint32_t i = 0; i < MAX_TEST_DATA_BYTES; i++)
    {
        uint32_t err_code;
        while (app_uart_put(tx_data[i]) != NRF_SUCCESS);

        nrf_delay_ms(10);
        err_code = app_uart_get(&rx_data);

        if ((rx_data != tx_data[i]) || (err_code != NRF_SUCCESS))
        {
            show_error();
        }
    }
    return;
}
#else
/* When UART is used for communication with the host do not use flow control.*/
//#define UART_HWFC APP_UART_FLOW_CONTROL_DISABLED //Define flow control as disabled
#define UART_HWFC APP_UART_FLOW_CONTROL_ENABLED//Define flow control as enabled

#endif


/**
 * @brief Function for main application entry.
 */
__STATIC_INLINE void nrf_gpio_cfg_output_high_drive(uint32_t pin_number)//Sets a pin as high drive mode
{
    nrf_gpio_cfg(
        pin_number,
        NRF_GPIO_PIN_DIR_OUTPUT,
        NRF_GPIO_PIN_INPUT_DISCONNECT,
        NRF_GPIO_PIN_NOPULL,
        NRF_GPIO_PIN_H0H1,
        NRF_GPIO_PIN_NOSENSE);
}

int main(void)
{
    uint32_t err_code;

    bsp_board_init(BSP_INIT_LEDS);
    //Using this because documentation states high bit rates may require GPIO's set as high drive
    //nrf_gpio_cfg_output_high_drive(RX_PIN_NUMBER);//RX high drive
    //nrf_gpio_cfg_output_high_drive(TX_PIN_NUMBER);//TX high drive
    //nrf_gpio_cfg_output_high_drive(RTS_PIN_NUMBER);//RTS high drive
    //nrf_gpio_cfg_output_high_drive(CTS_PIN_NUMBER);//CTS high drive
    const app_uart_comm_params_t comm_params =
      {
          RX_PIN_NUMBER,
          TX_PIN_NUMBER,
          RTS_PIN_NUMBER,
          CTS_PIN_NUMBER,
          UART_HWFC,
/*          false,
#if defined (UARTE_PRESENT)
          NRF_UARTE_BAUDRATE_115200
#else
          NRF_UARTE_BAUDRATE_115200
#endif
*/

#if defined (UART_PRESENT)
          NRF_UART_BAUDRATE_115200
#else
          NRF_UARTE_BAUDRATE_115200
#endif

      };

    APP_UART_FIFO_INIT(&comm_params,
                         UART_RX_BUF_SIZE,
                         UART_TX_BUF_SIZE,
                         uart_error_handle,
                         APP_IRQ_PRIORITY_LOWEST,
                         err_code);

    APP_ERROR_CHECK(err_code);

#ifndef ENABLE_LOOPBACK_TEST
    //printf("\r\nUART example started.\r\n");

    while (true)
    {
        uint8_t cr = 0x00;
        while (app_uart_get(&cr) != NRF_SUCCESS);
        //while (app_uart_put(cr)  != NRF_SUCCESS);
        if (cr == 't' || cr == 't')
        {
            //printf("\r\n Test passed\r\n");
        }
        if (cr == 'q' || cr == 'Q')
        {
            //printf(" \r\nExit!\r\n");

            while (true)
            {
                // Do nothing.
            }
        }
    }
#else

    // This part of the example is just for testing the loopback .
    while (true)
    {
        uart_loopback_test();
    }
#endif
}


/** @} */

Debugger goes from this:

To this:

And no further stepping over action does anything and the value of cr is symbol 0X00, this is what I declare it as.

[Einar Thorsrud]

I see. There is not much that could go wrong here. Can you test the simplified code I uploaded, and the pins I use there? I have verified that it works on my end, with and without flow control (though not with your sensor, just with another DK sending data regularly).

[Thomas]

I've tried your code an unfortunately I can not get it to work.

//Pin definitions for the UART board
#define RX_PIN_NUMBER  NRF_GPIO_PIN_MAP(0,26)//8
#define TX_PIN_NUMBER  NRF_GPIO_PIN_MAP(0,27)//6
#define CTS_PIN_NUMBER NRF_GPIO_PIN_MAP(0,28)//7
#define RTS_PIN_NUMBER NRF_GPIO_PIN_MAP(0,29)//5

Once again it gets to the app_uart_get line and does not go through the while loop.

Here is an image of my hardware setup.

Also I read in the documentation that for high data rates high drive might be needed. Could this be the issue?

Also don't know if it will help but, here is my CPU current context:

[Einar Thorsrud]

Hi,

That's strange. I cannot see if the individual pins are correct from the photo, but the pin configuration is the same as I used with the code from my previous post. Can you try to set breakpoints at both line 129 and line 130 and see? Does it still not move between them?

[Thomas]

The pinouts are : RX 26, TX 27, Cts 28 and Rts 29. 

Also no it does not move between lines 129 and 130. It breaks at 129, then when i let the breakpoint go nothing happens.

[Thomas]

What is the data coming out of your UART device and going into the nordic board, is it a similar format to my data (shown above ASCII data). As my data is received with \r\n at the end not sure if that is an issue. Also what are your specific pin outs? Just to remove as much variance as possible. Also what configuration settings do I need in my sdk_config.h I've not changed anything but, want to double check.

Also did you use the NRF52840 for you test?