DFU_public_key.c won't compile.

[SL06]

I have create a new DFU_public_key.c file with nrf_util and replace the existing file in the dfu_req_handling folder (MacOSX).

I had to change the name of the nRF5_SDK_14.2-2.0_17b948a  to nRF5_SDK_14  because Terminal.app had problem with the name while navigating directories.

When I compile the program with the new key in place,  I have the following compiling error :

Compiling ‘dfu_public_key.c’   

expected '}' before numeric constant

to match this '{'

The error point at the second 0x....  line (line 11).

Here is the file with the key hidden:

/* This file was automatically generated by nrfutil on 2019-12-13 (YY-MM-DD) at 15:42:07 */

#include "stdint.h"
#include "compiler_abstraction.h"

/** @brief Public key used to verify DFU images */
__ALIGN(4) const uint8_t pk[64] =
{
    0x....
    0x....
};

I don't see the problem with the file.  

Help would be appreciate.   Thanks

[Edvin]

Hello,

What version of nrfutil do you use? You can check by using the command "nrfutil version".

What compiler do you use? Is it possible to send the dfu_public_key.c file (or a separate dfu_public_key.c that you don't intend to use, but can replicate the problem)?

What command did you use to generate the keys?

Can you try with the attached dfu_public_key.c? Does that compile?

Fullscreen dfu_public_key.c Download

/* This file was automatically generated by nrfutil on 2019-12-16 (YY-MM-DD) at 14:00:14 */

#include "stdint.h"
#include "compiler_abstraction.h"

/** @brief Public key used to verify DFU images */
__ALIGN(4) const uint8_t pk[64] =
{
    0xfe, 0x9e, 0x34, 0x2f, 0x68, 0x35, 0x1d, 0x0a, 0x24, 0x5d, 0x7f, 0x50, 0x36, 0x67, 0xa7, 0x73, 0xb9, 0x7f, 0xbd, 0x76, 0x82, 0x9f, 0x96, 0xf1, 0x43, 0xad, 0x70, 0xf8, 0x6a, 0x24, 0x50, 0x09
    0x65, 0x5a, 0x05, 0x62, 0xf4, 0x97, 0xe0, 0x8f, 0xaa, 0xc0, 0x1a, 0x2a, 0x38, 0xdb, 0x3a, 0x43, 0x33, 0x25, 0xcb, 0xcc, 0xae, 0x94, 0xa3, 0x42, 0x3a, 0x5e, 0x4d, 0xc1, 0x3f, 0xe3, 0xe3, 0x34
};

BR,
Edvin

[Edvin]

Sorry. I checked now, and I saw the same behavior. It seems like there is a bug in the latest version of nrfutil. the dfu_public_key.c (or whatever you choose to call it) is missing a comma at the end of the first line of the key. So if you add this comma, it should compile. Taking the dfu_public_key.c that I sent you, it should look like this after the fix:

/* This file was automatically generated by nrfutil on 2019-12-16 (YY-MM-DD) at 14:00:14 */

#include "stdint.h"
#include "compiler_abstraction.h"

/** @brief Public key used to verify DFU images */
__ALIGN(4) const uint8_t pk[64] =
{
    0xfe, 0x9e, 0x34, 0x2f, 0x68, 0x35, 0x1d, 0x0a, 0x24, 0x5d, 0x7f, 0x50, 0x36, 0x67, 0xa7, 0x73, 0xb9, 0x7f, 0xbd, 0x76, 0x82, 0x9f, 0x96, 0xf1, 0x43, 0xad, 0x70, 0xf8, 0x6a, 0x24, 0x50, 0x09,
    0x65, 0x5a, 0x05, 0x62, 0xf4, 0x97, 0xe0, 0x8f, 0xaa, 0xc0, 0x1a, 0x2a, 0x38, 0xdb, 0x3a, 0x43, 0x33, 0x25, 0xcb, 0xcc, 0xae, 0x94, 0xa3, 0x42, 0x3a, 0x5e, 0x4d, 0xc1, 0x3f, 0xe3, 0xe3, 0x34
};

I will report this internally. Thank you for the feedback.

Best regards,

Edvin

[SL06]

Thanks,  adding the comma have solved this issue.  Now I have the following error :
Compiling ‘micro_ecc_lib_init.c’
uECC.h: No such file or directory

uECC.h is not part of the SDK as is , but there is the micro-eco folder present . I am trying to follow instruction on Nordic infocenter for SDK14.2.  I am using the nrf52DK + SES.  There is nrf52nf_armgcc  and nrf52hf_armgcc  file in that folder.  Which one should I use?

I am puzzled with this issue since I tough that I had successfully compiled the BLEsecure DFU booth loader once without issue. After I change the SDK folder name, nothing worked.  May be I was dreaming...  

[Edvin]

Open the folder "nRF5_SDK_14.2.0_17b948a\external\micro-ecc" and run the "build_all.bat" script (double click it). 

If it can't find the micro_ecc_lib_init.c it is probably because you have changed the path. It shouldn't be dependent on the name of the SDK folder itself, but if you have moved things around inside the SDK, then the relative paths will not match anymore. Try to right click the file in project explorer, and select "options for ..." or something similar, depending on what compiler/IDE you are using.

Then you can see what path it expects this file to be in. Make sure that it is correct.

Best regards,

Edvin

[SL06]

I have tried to compile  the "build_all.bat" script on my Mac (OS 10.14.6) without success.  The script first ask me to install Java SDK.  I have install the 13.01 version.  When I ran the script a sedan time after reboot I had to error message :  

SLMini-I5-172:~ slareau$ /Users/slareau/nrf52_development/nRF5_SDK_14.2-2.0_17b948a\ /external/micro-ecc/build_all.bat ; exit;

/Users/slareau/nrf52_development/nRF5_SDK_14.2-2.0_17b948a /external/micro-ecc/build_all.bat: line 1: @ECHO: command not found

/Users/slareau/nrf52_development/nRF5_SDK_14.2-2.0_17b948a /external/micro-ecc/b: command not found2: 

/Users/slareau/nrf52_development/nRF5_SDK_14.2-2.0_17b948a /external/micro-ecc/build_all.bat: line 3: syntax error near unexpected token `('

/Users/slareau/nrf52_development/nRF5_SDK_14.2-2.0_17b948a /external/micro-ecc/build_all.bat: line 3: `:: This script will use git (must be in %PATH%) and arm-n'ne-eabi tools in combination with GNU Make 

logout

Saving session...

...copying shared history...

...saving history...truncating history files...

...completed.

I have also tried to download and reinstall the SDK14.  

Can I compile those file on my PC and transfer those back on my Mac ?  Or maybe you can just send me the proper uECC.c and uECC.h file...

Regards,