nRF52840 SDK 16 Peripheral Blinky with CODED PHY

[SRall]

What all do I need to modify in the Blinky peripheral (from SDK 16) with in order for the 840 DK to advertise and connect with CODED PHY in long range mode?

My code compiles but the advertising LED hasn't lit and I get a fatal error in the advertising parameters. The error I get is NRF_ERROR_INVALID_PARAM when calling sd_ble_gap_adv_set_configure. 

So far I've changed the primary and secondary phys to PHY_CODED and the properties type to BLE_GAP_ADV_TYPE_EXTENDED_CONNECTABLE_NONSCANNABLE_UNDIRECTED. 

Thank you for your time, 

Sam

[Simonr]

Yes, I can explain! I'm sorry I didn't mention that initially, but extended advertising (which is necessary to run Coded PHY) does not support scan response packets, as it transfers extra data in the secondary channels instead. Setting the scan response data length to 0 will fix this. 

Best regards,

Simon

[SRall]

Ok but what about the scan_req_notification=1? Can you explain what's happening in this advertising init function I posted?