DIS client ble_dis_c_on_db_disc_evt never fire due to error in source code

[Vyacheslav Lebets]

HI !
I found an error in the source code because of which the db discovery event handler on DIS client does not work, namely:
in the function ble_dis_c_on_db_disc_evt ()

in code:

if ((p_ble_dis_c->evt_handler == NULL) ||
    (p_ble_dis_c->conn_handle == p_evt->conn_handle))
{
    return;
}

function always return here.

Condition  "p_ble_dis_c->conn_handle == p_evt->conn_handle"  is correct to continue the function, and not to exit it.
For the code to work correctly, need to set the condition non equally like this:

p_ble_dis_c->conn_handle != p_evt->conn_handle

and get the following code:

if ((p_ble_dis_c->evt_handler == NULL) ||
    (p_ble_dis_c->conn_handle != p_evt->conn_handle))
{
    return;
}

All health and good luck!

[Susheel Nuguru]

You seem right, that if condition does not seem necessary. It does not harm to discover the known service. Please remove that if condition completely to match it with other central discovery procedures.

Thank you for reporting it.

[Susheel Nuguru]

for your reference, created internal ticket to change this. NRFFOETT-2455

[Vyacheslav Lebets]

Ok, thanks !