nAN-36 + nRF51822 PCA10028 APP_BUTTON_INIT [SOLVED]

[bulbse]

in the code below, the keil IDE is flagging with red squiggly APP_BUTTON_INIT, claiming that it is an undefined symbol. It also says that this implicit declaration of 'APP_BUTTON_INIT' is not valid for c99

I called out the proper GPIOTE function before this and I have the "app_button.h" included. I dont know what to do this has been driving me crazy.

    static void buttons_init(void)
{   
    // Note: Array must be static because a pointer to it will be saved in the Button handler
    //       module.	
    static app_button_cfg_t buttons[] =
    {
        {WAKEUP_BUTTON_PIN, false, BUTTON_PULL, NULL},
        {LEDBUTTON_BUTTON_PIN_NO, false, BUTTON_PULL, button_event_handler}
    };

    APP_BUTTON_INIT(buttons, sizeof(buttons) / sizeof(buttons[0]), BUTTON_DETECTION_DELAY, true);
			
}

TL;DR ANSWER Below:

The Correct solution was to replace

APP_BUTTON_INIT(buttons, sizeof(buttons) / sizeof(buttons[0]), BUTTON_DETECTION_DELAY, true);

with

app_button_init(buttons, sizeof(buttons) / sizeof(buttons[0]), BUTTON_DETECTION_DELAY);

differences Note: the method is lower case, and the last parameter within said method is no longer defined.

[Stian Røed Hafskjold]

The only way I can reproduce this is if I deliberately delete the #define APP_BUTTON_INIT(...) definition in app_button.h.

Are you sure there are no typos or something in app_button.h? Is the file added to the include paths?

If you download the example from git again (github.com/.../nrf51-ble-app-lbs), and put it in the SDK 7.1 examples/ble_peripheral folder without modifying it, does it compile?

What happens if you replace the call to the APP_BUTTON_INIT macro in main.c with a direct call to app_button_init()? like this:

app_button_init(buttons, sizeof(buttons) / sizeof(buttons[0]), BUTTON_DETECTION_DELAY, app_button_evt_schedule);

[bulbse]

I couldn't find "#define APP_BUTTON_INIT()" in my app_button.h, Am i supposed to define it? I didn't touch any files other than what the app note instructs.

[bulbse]

I also tried replacing the call, you included an additional parameter that was not defined in the header file definition ..., app_button_evt_schedule)... I removed that last parameter and it compiled.

the app note calls out a function that is not defined in my header why is that?

[Stian Røed Hafskjold]

APP_BUTTON_INIT() is defined on line 92 in app_button.h if you are using SDK 7.1. If it is not there, where did you download the SDK? Are you sure you haven't altered the file in another project or something? It should compile right out of the box.

[bulbse]

out of the box it fails, I got the most recent sdk and keil. I grabbed the git hub example because there were a lot of inconsistencies with the app note and the current release. since the git hub project did not compile i took the source files from that directory and added it to a new template project to make this thing work. which it didn't. however the app_button_init is defined differently in the current sdk then it was from when the app note was written. I would seriously consider re-writing that app note. Thanks for allowing me to identify the answer.

The Correct solution was to replace

APP_BUTTON_INIT(buttons, sizeof(buttons) / sizeof(buttons[0]), BUTTON_DETECTION_DELAY, true);

with

app_button_init(buttons, sizeof(buttons) / sizeof(buttons[0]), BUTTON_DETECTION_DELAY);

[Stian Røed Hafskjold]

You are correct that if you got the most recent SDK (which is version 8.0) APP_BUTTON_INIT() is not defined. Thank you for pointing this out. The Github version of the lbs example is based on SDK 7.1 (which is stated in the readme file). The nAN-36 app note is really old now, and in my opinion should have been removed from the site, so I understand you frustration, sorry about that. We are working on an alternative to the app note. We sure also have to update the Github example to the recent SDK 8 version which was released a few days ago.