apply_old_config.h issue

[lemon]

Hi,

In apply_old_config.h ,here is the code:

for example:

#if defined(SYSTICK_ENABLED)

#undef NRFX_SYSTICK_ENABLED
#define NRFX_SYSTICK_ENABLED  SYSTICK_ENABLED

#endif // defined(SYSTICK_ENABLED)

If I set SYSTICK_ENABLED =0 in sdk_config,here will overwrite the macro define because #if defined(SYSTICK_ENABLED) is true.

This makes me very confused,maybe here can change to #if defined(SYSTICK_ENABLED ) && SYSTICK_ENABLED  ?

[Edvin]

Hello,

Thank you for reporting.

I agree that it is a bit confusing, but if we set it to your suggestion, then that would lead to other confused users saying something like:

I tried to disable SYSTICK_ENABLED, but it is re-enabled in apply_old_config.h.

I really don't see any good implementation as long as we have two sets of configurations that control the same thing, which is probably the real issue.

Good thing you found the apply_old_config.h file. As you probably see, either use the "legacy" definition names, or comment out the SYSTICK_ENABLED from your sdk_config.h file.

I will forward this to our SDK team.

BR,

Edvin

[lemon]

Hi，

Yes，now It seems that there is no good implementation to avoid this question.

Maybe the future nRF5 SDK could ignore the legacy driver, otherwise when beginners migrate code ,there will be

lots of problems.

Thsnks for your reply.

BRs,

Lemon

[Shrey]

Hello, I can confirm that this issue isn't resolved still in SDK17 which means that if we don't want to use old style configuration by having the following

sdk_config.h

#define PPI_ENABLED 0

#define NRFX_PPI_ENABLED 1

The apply_old_config.h redefines NRFX_PPI_ENABLED as below:

#if defined(PPI_ENABLED)

#undef NRFX_PPI_ENABLED
#define NRFX_PPI_ENABLED PPI_ENABLED

[lemon]

Hi，Shrey，

Thanks for your reply.

Brs,

Lemon