SLM UDP proxy serial port

Question

Hi

I'm testing the SLM application in nRF Connect SDK ver 1.3.1 on nRF9160 PDK ver 0.8.2 using the LTE Link Monitor v3.5.0

Giving the following commands, the UART stop working:

2020-10-07T11:30:58.750Z DEBUG modem >> at
2020-10-07T11:30:58.876Z DEBUG modem << OK
2020-10-07T11:31:03.833Z DEBUG modem >> AT+CFUN?
2020-10-07T11:31:03.957Z DEBUG modem << +CFUN: 0
2020-10-07T11:31:03.997Z DEBUG modem << OK
2020-10-07T11:31:05.703Z DEBUG modem >> AT+CFUN=1
2020-10-07T11:31:05.828Z DEBUG modem << OK
2020-10-07T11:31:13.421Z DEBUG modem >> at+cereg?
2020-10-07T11:31:13.539Z DEBUG modem << +CEREG: 0,1,"7851","0129B401",7
2020-10-07T11:31:13.578Z DEBUG modem << OK
2020-10-07T11:31:18.501Z DEBUG modem >> at#xudpcli=1,"xx.xxx.xx.xxx",xxxx
2020-10-07T11:31:18.618Z DEBUG modem << #XUDPCLI: 1 connected
2020-10-07T11:31:18.623Z DEBUG modem << OK
2020-10-07T11:31:22.477Z DEBUG modem >> at#xudpcli=0
2020-10-07T11:31:22.594Z DEBUG modem << OK
2020-10-07T11:31:25.456Z DEBUG modem >> at+cereg?
2020-10-07T11:31:25.575Z DEBUG modem << +CEREG: 0,1,"7851","0129B401",7
2020-10-07T11:31:25.614Z DEBUG modem << OK
2020-10-07T11:31:29.486Z DEBUG modem >> at#xudpcli=1,"xx.xxx.xx.xxx",xxxx
2020-10-07T11:31:29.606Z DEBUG modem << #XUDPCLI: 1 connected
2020-10-07T11:31:29.611Z DEBUG modem << OK
2020-10-07T11:31:31.755Z DEBUG modem >> at#xudpcli=0
2020-10-07T11:31:31.868Z DEBUG modem << OK
2020-10-07T11:31:34.931Z DEBUG modem >> at+cereg?
2020-10-07T11:31:35.931Z ERROR Error: 'at+cereg?
' timed out

Giving a proprietary AT cmd like at#xslmver work all the time:

2020-10-07T11:43:30.672Z DEBUG modem >> at
2020-10-07T11:43:30.678Z DEBUG modem << OK
2020-10-07T11:43:34.349Z DEBUG modem >> at+cereg?
2020-10-07T11:43:34.472Z DEBUG modem << +CEREG: 0,1,"7851","0129B401",7
2020-10-07T11:43:34.512Z DEBUG modem << OK
2020-10-07T11:43:38.357Z DEBUG modem >> at#xslmver
2020-10-07T11:43:38.471Z DEBUG modem << #XSLMVER: 1.2
2020-10-07T11:43:38.475Z DEBUG modem << OK
2020-10-07T11:43:41.016Z DEBUG modem >> at#xudpcli=1,"xx.xxx.xx.xxx",xxxx
2020-10-07T11:43:41.135Z DEBUG modem << #XUDPCLI: 1 connected
2020-10-07T11:43:41.139Z DEBUG modem << OK
2020-10-07T11:43:42.435Z DEBUG modem >> at#xudpcli=0
2020-10-07T11:43:42.555Z DEBUG modem << OK
2020-10-07T11:43:45.605Z DEBUG modem >> at#xslmver
2020-10-07T11:43:45.614Z DEBUG modem << #XSLMVER: 1.2
2020-10-07T11:43:45.728Z DEBUG modem << OK
2020-10-07T11:43:48.713Z DEBUG modem >> at#xudpcli=1,"xx.xxx.xx.xxx",xxxx
2020-10-07T11:43:48.828Z DEBUG modem << #XUDPCLI: 1 connected
2020-10-07T11:43:48.833Z DEBUG modem << OK
2020-10-07T11:43:51.361Z DEBUG modem >> at#xudpcli=0
2020-10-07T11:43:51.476Z DEBUG modem << OK
2020-10-07T11:43:53.397Z DEBUG modem >> at#xslmver
2020-10-07T11:43:53.405Z DEBUG modem << #XSLMVER: 1.2
2020-10-07T11:43:53.409Z DEBUG modem << OK
2020-10-07T11:43:56.797Z DEBUG modem >> at#xudpcli=1,"xx.xxx.xx.xxx",xxxx
2020-10-07T11:43:56.919Z DEBUG modem << #XUDPCLI: 1 connected
2020-10-07T11:43:56.925Z DEBUG modem << OK
2020-10-07T11:43:57.844Z DEBUG modem >> at#xudpcli=0
2020-10-07T11:43:57.976Z DEBUG modem << OK
2020-10-07T11:44:01.346Z DEBUG modem >> at#xslmver
2020-10-07T11:44:01.464Z DEBUG modem << #XSLMVER: 1.2
2020-10-07T11:44:01.468Z DEBUG modem << OK

Is there a way to allow for standard AT cmd's after the UDP proxy has been enabled/disabled?

Carl Richard · Accepted Answer

Hi, Bard! We have found the bug, and I have a (temporary) solution ready. The issue is related to non-graceful shutdown of the UDP thread(in the middle of a recvfrom(...)), leading to problems with the sockets used by the at_cmd library. Please replace /src/tcpip_proxy/slm_at_udp_proxy.c with the following file: Fullscreen 5700.slm_at_udp_proxy.c Download /* * Copyright (c) 2020 Nordic Semiconductor ASA * * SPDX-License-Identifier: LicenseRef-BSD-5-Clause-Nordic */ #include #include #include #include #include #include #include #include "slm_util.h" #include "slm_at_host.h" #include "slm_at_udp_proxy.h" LOG_MODULE_REGISTER(udp_proxy, CONFIG_SLM_LOG_LEVEL); #define THREAD_STACK_SIZE (KB(1) + NET_IPV4_MTU) #define THREAD_PRIORITY K_LOWEST_APPLICATION_THREAD_PRIO #define DATA_HEX_MAX_SIZE (2 * NET_IPV4_MTU) /* * Known limitation in this version * - Multiple concurrent * - Receive more than IPv4 MTU one-time * - IPv6 support * - does not support proxy */ /**@brief Proxy operations. */ enum slm_udp_proxy_operation { AT_SERVER_STOP, AT_CLIENT_DISCONNECT = AT_SERVER_STOP, AT_SERVER_START, AT_CLIENT_CONNECT = AT_SERVER_START }; /**@brief Proxy roles. */ enum slm_udp_proxy_role { AT_UDP_ROLE_CLIENT, AT_UDP_ROLE_SERVER }; /**@brief List of supported AT commands. */ enum slm_udp_proxy_at_cmd_type { AT_UDP_SERVER, AT_UDP_CLIENT, AT_UDP_SEND, AT_UDP_PROXY_MAX }; /** forward declaration of cmd handlers **/ static int handle_at_udp_server(enum at_cmd_type cmd_type); static int handle_at_udp_client(enum at_cmd_type cmd_type); static int handle_at_udp_send(enum at_cmd_type cmd_type); /**@brief SLM AT Command list type. */ static slm_at_cmd_list_t m_udp_proxy_at_list[AT_UDP_PROXY_MAX] = { {AT_UDP_SERVER, "AT#XUDPSVR", handle_at_udp_server}, {AT_UDP_CLIENT, "AT#XUDPCLI", handle_at_udp_client}, {AT_UDP_SEND, "AT#XUDPSEND", handle_at_udp_send}, }; static u8_t data_hex[DATA_HEX_MAX_SIZE]; static struct k_thread udp_thread; static K_THREAD_STACK_DEFINE(udp_thread_stack, THREAD_STACK_SIZE); static k_tid_t udp_thread_id; static struct sockaddr_in remote; static int udp_sock; /* global functions defined in different files */ void rsp_send(const u8_t *str, size_t len); /* global variable defined in different files */ extern struct at_param_list at_param_list; extern struct modem_param_info modem_param; extern char rsp_buf[CONFIG_AT_CMD_RESPONSE_MAX_LEN]; /** forward declaration of thread function **/ static void udp_thread_func(void *p1, void *p2, void *p3); static int do_udp_server_start(u16_t port, int sec_tag) { int ret = 0; int addr_len; struct sockaddr_in local; /* Open socket */ if (sec_tag == INVALID_SEC_TAG) { udp_sock = socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP); } else { sprintf(rsp_buf, "#XUDPSVR: DTLS Server not supported "); rsp_send(rsp_buf, strlen(rsp_buf)); return -ENOTSUP; } if (udp_sock < 0) { LOG_ERR("socket() failed: %d", -errno); sprintf(rsp_buf, "#XUDPSVR: %d ", -errno); rsp_send(rsp_buf, strlen(rsp_buf)); return -errno; } /* Bind to local port */ local.sin_family = AF_INET; local.sin_port = htons(port); ret = modem_info_params_get(&modem_param); if (ret) { LOG_ERR("Unable to obtain modem parameters (%d)", ret); close(udp_sock); return ret; } addr_len = strlen(modem_param.network.ip_address.value_string); if (addr_len == 0) { LOG_ERR("LTE not connected yet"); close(udp_sock); return -EINVAL; } if (!check_for_ipv4(modem_param.network.ip_address.value_string, addr_len)) { LOG_ERR("Invalid local address"); close(udp_sock); return -EINVAL; } if (inet_pton(AF_INET, modem_param.network.ip_address.value_string, &local.sin_addr) != 1) { LOG_ERR("Parse local IP address failed: %d", -errno); close(udp_sock); return -EINVAL; } ret = bind(udp_sock, (struct sockaddr *)&local, sizeof(struct sockaddr_in)); if (ret) { LOG_ERR("bind() failed: %d", -errno); sprintf(rsp_buf, "#XUDPSVR: %d ", -errno); rsp_send(rsp_buf, strlen(rsp_buf)); close(udp_sock); return -errno; } udp_thread_id = k_thread_create(&udp_thread, udp_thread_stack, K_THREAD_STACK_SIZEOF(udp_thread_stack), udp_thread_func, NULL, NULL, NULL, THREAD_PRIORITY, K_USER, K_NO_WAIT); sprintf(rsp_buf, "#XUDPSVR: %d started ", udp_sock); rsp_send(rsp_buf, strlen(rsp_buf)); LOG_DBG("UDP server started"); return ret; } static int do_udp_server_stop(int error) { int ret = 0; if (udp_sock > 0) { k_thread_abort(udp_thread_id); ret = close(udp_sock); if (ret < 0) { LOG_WRN("close() failed: %d", -errno); ret = -errno; } udp_sock = INVALID_SOCKET; sprintf(rsp_buf, "#XUDPSVR: %d stopped ", error); rsp_send(rsp_buf, strlen(rsp_buf)); LOG_DBG("UDP server stopped"); } return ret; } static int do_udp_client_connect(const char *url, u16_t port, int sec_tag) { int ret; /* Open socket */ if (sec_tag == INVALID_SEC_TAG) { udp_sock = socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP); } else { udp_sock = socket(AF_INET, SOCK_DGRAM, IPPROTO_DTLS_1_2); } if (udp_sock < 0) { LOG_ERR("socket() failed: %d", -errno); sprintf(rsp_buf, "#XUDPCLI: %d ", -errno); rsp_send(rsp_buf, strlen(rsp_buf)); return -errno; } if (sec_tag != INVALID_SEC_TAG) { sec_tag_t sec_tag_list[1] = { sec_tag }; ret = setsockopt(udp_sock, SOL_TLS, TLS_SEC_TAG_LIST, sec_tag_list, sizeof(sec_tag_t)); if (ret) { LOG_ERR("set tag list failed: %d", -errno); sprintf(rsp_buf, "#XUDPCLI: %d ", -errno); rsp_send(rsp_buf, strlen(rsp_buf)); close(udp_sock); return -errno; } } /* Connect to remote host */ if (check_for_ipv4(url, strlen(url))) { remote.sin_family = AF_INET; remote.sin_port = htons(port); LOG_DBG("IPv4 Address %s", log_strdup(url)); /* NOTE inet_pton() returns 1 as success */ ret = inet_pton(AF_INET, url, &remote.sin_addr); if (ret != 1) { LOG_ERR("inet_pton() failed: %d", ret); close(udp_sock); return -EINVAL; } } else { struct addrinfo *result; struct addrinfo hints = { .ai_family = AF_INET, .ai_socktype = SOCK_DGRAM }; ret = getaddrinfo(url, NULL, &hints, &result); if (ret || result == NULL) { LOG_ERR("getaddrinfo() failed: %d", ret); close(udp_sock); return -EINVAL; } remote.sin_family = AF_INET; remote.sin_port = htons(port); remote.sin_addr.s_addr = ((struct sockaddr_in *)result->ai_addr)->sin_addr.s_addr; /* Free the address. */ freeaddrinfo(result); } ret = connect(udp_sock, (struct sockaddr *)&remote, sizeof(struct sockaddr_in)); if (ret < 0) { LOG_ERR("connect() failed: %d", -errno); sprintf(rsp_buf, "#XUDPCLI: %d ", -errno); rsp_send(rsp_buf, strlen(rsp_buf)); close(udp_sock); return -errno; } udp_thread_id = k_thread_create(&udp_thread, udp_thread_stack, K_THREAD_STACK_SIZEOF(udp_thread_stack), udp_thread_func, NULL, NULL, NULL, THREAD_PRIORITY, K_USER, K_NO_WAIT); sprintf(rsp_buf, "#XUDPCLI: %d connected ", udp_sock); rsp_send(rsp_buf, strlen(rsp_buf)); return ret; } static volatile bool _terminate_thread = false; static int do_udp_client_disconnect(int error) { int ret = 0; if (udp_sock > 0) { _terminate_thread = true; //k_thread_abort(udp_thread_id); k_thread_join(udp_thread_id, K_FOREVER); ret = close(udp_sock); if (ret < 0) { LOG_WRN("close() failed: %d", -errno); ret = -errno; } udp_sock = INVALID_SOCKET; if (error) { sprintf(rsp_buf, "#XUDPCLI: %d disconnected ", error); rsp_send(rsp_buf, strlen(rsp_buf)); } _terminate_thread = false; } return ret; } static int do_udp_send(const u8_t *data, int datalen) { int ret = 0; u32_t offset = 0; if (udp_sock == INVALID_SOCKET) { LOG_ERR("Not connected yet"); return -EINVAL; } while (offset < datalen) { ret = sendto(udp_sock, data + offset, datalen - offset, 0, (struct sockaddr *)&remote, sizeof(remote)); if (ret < 0) { LOG_ERR("send() failed: %d", -errno); if (errno != EAGAIN && errno != ETIMEDOUT) { do_udp_server_stop(-errno); } else { sprintf(rsp_buf, "#XUDPSEND: %d ", -errno); rsp_send(rsp_buf, strlen(rsp_buf)); } ret = -errno; break; } offset += ret; } sprintf(rsp_buf, "#XUDPSEND: %d ", offset); rsp_send(rsp_buf, strlen(rsp_buf)); if (ret >= 0) { return 0; } else { return ret; } } static void udp_thread_func(void *p1, void *p2, void *p3) { int ret; int size = sizeof(struct sockaddr_in); char data[NET_IPV4_MTU]; ARG_UNUSED(p1); ARG_UNUSED(p2); ARG_UNUSED(p3); do { struct timeval timeout = {1, 0}; fd_set readSet; FD_ZERO(&readSet); FD_SET(udp_sock, &readSet); if (select(udp_sock+1, &readSet, NULL, NULL, &timeout) >= 0) { if(_terminate_thread) { LOG_DBG("UDP_THREAD: terminating"); return; } else if (FD_ISSET(udp_sock, &readSet)) { ret = recvfrom(udp_sock, data, NET_IPV4_MTU, 0, (struct sockaddr *)&remote, &size); if (ret < 0) { LOG_WRN("recv() error: %d", -errno); continue; } if (ret == 0) { continue; } if (slm_util_hex_check(data, ret)) { ret = slm_util_htoa(data, ret, data_hex, DATA_HEX_MAX_SIZE); if (ret > 0) { sprintf(rsp_buf, "#XUDPRECV: %d, %d ", DATATYPE_HEXADECIMAL, ret); rsp_send(rsp_buf, strlen(rsp_buf)); rsp_send(data_hex, ret); rsp_send(" ", 2); } else { LOG_WRN("hex convert error: %d", ret); } } else { sprintf(rsp_buf, "#XUDPRECV: %d, %d ", DATATYPE_PLAINTEXT, ret); rsp_send(rsp_buf, strlen(rsp_buf)); rsp_send(data, ret); rsp_send(" ", 2); } } } else LOG_ERR("UDP_THREAD: select"); } while (true); LOG_DBG("Quit receive thread"); } /**@brief handle AT#XUDPSVR commands * AT#XUDPSVR=[,[,[sec_tag]] * AT#XUDPSVR? READ command not supported * AT#XUDPSVR=? */ static int handle_at_udp_server(enum at_cmd_type cmd_type) { int err = -EINVAL; u16_t op; int param_count = at_params_valid_count_get(&at_param_list); switch (cmd_type) { case AT_CMD_TYPE_SET_COMMAND: if (param_count < 2) { return -EINVAL; } err = at_params_short_get(&at_param_list, 1, &op); if (err) { return err; } if (op == AT_SERVER_START) { u16_t port; sec_tag_t sec_tag = INVALID_SEC_TAG; if (param_count < 3) { return -EINVAL; } err = at_params_short_get(&at_param_list, 2, &port); if (err) { return err; } if (param_count > 3) { at_params_int_get(&at_param_list, 3, &sec_tag); } if (udp_sock > 0) { LOG_WRN("Server is running"); return -EINVAL; } err = do_udp_server_start(port, sec_tag); } else if (op == AT_SERVER_STOP) { if (udp_sock < 0) { LOG_WRN("Server is not running"); return -EINVAL; } err = do_udp_server_stop(0); } break; case AT_CMD_TYPE_TEST_COMMAND: sprintf(rsp_buf, "#XUDPSVR: (%d, %d),, ", AT_SERVER_STOP, AT_SERVER_START); rsp_send(rsp_buf, strlen(rsp_buf)); err = 0; break; default: break; } return err; } /**@brief handle AT#XUDPCLI commands * AT#XUDPCLI=[,,[,[sec_tag]] * AT#XUDPCLI? READ command not supported * AT#XUDPCLI=? */ static int handle_at_udp_client(enum at_cmd_type cmd_type) { int err = -EINVAL; u16_t op; int param_count = at_params_valid_count_get(&at_param_list); switch (cmd_type) { case AT_CMD_TYPE_SET_COMMAND: if (param_count < 2) { return -EINVAL; } err = at_params_short_get(&at_param_list, 1, &op); if (err) { return err; } if (op == AT_CLIENT_CONNECT) { u16_t port; char url[TCPIP_MAX_URL]; int size = TCPIP_MAX_URL; sec_tag_t sec_tag = INVALID_SEC_TAG; if (param_count < 4) { return -EINVAL; } err = at_params_string_get(&at_param_list, 2, url, &size); if (err) { return err; } url[size] = '\0'; err = at_params_short_get(&at_param_list, 3, &port); if (err) { return err; } if (param_count > 4) { at_params_int_get(&at_param_list, 4, &sec_tag); } err = do_udp_client_connect(url, port, sec_tag); } else if (op == AT_CLIENT_DISCONNECT) { if (udp_sock < 0) { LOG_WRN("Client is not connected"); return -EINVAL; } err = do_udp_client_disconnect(0); } break; case AT_CMD_TYPE_TEST_COMMAND: sprintf(rsp_buf, "#XUDPCLI: (%d, %d),,, ", AT_CLIENT_DISCONNECT, AT_CLIENT_CONNECT); rsp_send(rsp_buf, strlen(rsp_buf)); err = 0; break; default: break; } return err; } /**@brief handle AT#XUDPSEND commands * AT#XUDPSEND=, * AT#XUDPSEND? READ command not supported * AT#XUDPSEND=? TEST command not supported */ static int handle_at_udp_send(enum at_cmd_type cmd_type) { int err = -EINVAL; u16_t datatype; char data[NET_IPV4_MTU]; int size = NET_IPV4_MTU; if (remote.sin_family == AF_UNSPEC || remote.sin_port == INVALID_PORT) { return err; } switch (cmd_type) { case AT_CMD_TYPE_SET_COMMAND: if (at_params_valid_count_get(&at_param_list) < 3) { return -EINVAL; } err = at_params_short_get(&at_param_list, 1, &datatype); if (err) { return err; } err = at_params_string_get(&at_param_list, 2, data, &size); if (err) { return err; } if (datatype == DATATYPE_HEXADECIMAL) { u8_t data_hex[size / 2]; err = slm_util_atoh(data, size, data_hex, size / 2); if (err > 0) { err = do_udp_send(data_hex, err); } } else { err = do_udp_send(data, size); } break; default: break; } return err; } /**@brief API to handle UDP Proxy AT commands */ int slm_at_udp_proxy_parse(const char *at_cmd) { int ret = -ENOTSUP; enum at_cmd_type type; for (int i = 0; i < AT_UDP_PROXY_MAX; i++) { if (slm_util_cmd_casecmp(at_cmd, m_udp_proxy_at_list[i].string)) { ret = at_parser_params_from_str(at_cmd, NULL, &at_param_list); if (ret) { LOG_ERR("Failed to parse AT command %d", ret); return -EINVAL; } type = at_parser_cmd_type_get(at_cmd); ret = m_udp_proxy_at_list[i].handler(type); break; } } return ret; } /**@brief API to list UDP Proxy AT commands */ void slm_at_udp_proxy_clac(void) { for (int i = 0; i < AT_UDP_PROXY_MAX; i++) { sprintf(rsp_buf, "%s ", m_udp_proxy_at_list[i].string); rsp_send(rsp_buf, strlen(rsp_buf)); } } /**@brief API to initialize UDP Proxy AT commands handler */ int slm_at_udp_proxy_init(void) { udp_sock = INVALID_SOCKET; remote.sin_family = AF_UNSPEC; remote.sin_port = INVALID_PORT; return 0; } /**@brief API to uninitialize UDP Proxy AT commands handler */ int slm_at_udp_proxy_uninit(void) { int ret; if (udp_sock > 0) { k_thread_abort(udp_thread_id); ret = close(udp_sock); if (ret < 0) { LOG_WRN("close() failed: %d", -errno); ret = -errno; } udp_sock = INVALID_SOCKET; } return 0; } Then replace /zephyr/subsys/net/lib/sockets/CMakeLists.txt with the following: Fullscreen 7446.CMakeLists.txt Download # SPDX-License-Identifier: Apache-2.0 zephyr_include_directories(.) zephyr_sources( getaddrinfo.c sockets.c sockets_select.c ) if(NOT CONFIG_NET_SOCKETS_OFFLOAD) zephyr_sources( sockets_select.c getnameinfo.c sockets_misc.c ) zephyr_sources_ifdef(CONFIG_NET_SOCKETS_SOCKOPT_TLS sockets_tls.c) zephyr_sources_ifdef(CONFIG_NET_SOCKETS_PACKET sockets_packet.c) zephyr_sources_ifdef(CONFIG_NET_SOCKETS_CAN sockets_can.c) endif() zephyr_sources_ifdef(CONFIG_NET_SOCKETS_OFFLOAD socket_offload.c) if(CONFIG_NET_SOCKETS_NET_MGMT) zephyr_sources(sockets_net_mgmt.c) zephyr_include_directories(${ZEPHYR_BASE}/subsys/net/ip) endif() if(CONFIG_SOCKS) zephyr_include_directories(${ZEPHYR_BASE}/subsys/net/lib/socks) endif() zephyr_sources_ifdef(CONFIG_NET_SOCKETPAIR socketpair.c) zephyr_link_libraries_ifdef(CONFIG_MBEDTLS mbedTLS) This should enable the normal "AT+" functions to continue working. Hope this works for you and please reach out if you need further assistance. I will also notify you when this bug is "officially" fixed. Best regards, Carl Richard

SLM UDP proxy serial port

Top Replies