SPIM not working after porting ncs from 1.2.0 to 1.4.2

[samermattar]

SoC nrf52840, nrf connect SDK v1.4.2

we have a board with 3 sensors connected with independent SPI interfaces.
after porting the code to ncs v1.4.2 from v1.2.0 the SPI communication stops working! 
I checked all the SPI pins (CS, mosi and clock) and they are toggling as expected and exactly the same as in version 1.2.0. However, the miso pin in version 1.4.2 doesn't respond to transactions!
this happens on all 3 sensors connected with SPI.

did anybody encounter a similar issue?`

thanks.

following is one the SPI devices in the device tree:

&spi3 {

  status = "okay";

  sck-pin = <37>;

  mosi-pin = <36>;

  miso-pin = <38>;

  #address-cells = <1>;

  #size-cells = <0>;

  compatible = "nordic,nrf-spim";

  cs-gpios = <&gpio1 7 0>;

  lis2dw12@0 {

    compatible = "st,lis2dw12";

    reg = <0>;

    irq-gpios = <&gpio1 3 0>;

    label = "LIS2DW12";

    spi-max-frequency = <8000000>;

  };

};

[GNotman]

I believe I ran into a similar issue.

I believe the issue is due to this commit:
https://github.com/zephyrproject-rtos/zephyr/commit/5963ebaf33bb542de1a7b2e1cf03b0af476e8dab

Which was added in Zephyr v2.4.0-rc1, which then made it into v1.4.x of the NRF SDK.

There is a new field in `spi_cs_control`, labelled `gpio_dt_flags`. 

This needs to be set to `GPIO_ACTIVE_LOW` for the standard CS pull-low behaviour, or `GPIO_ACTIVE_HIGH` for the inverse.

Unfortunately, `GPIO_ACTIVE_HIGH == 0` which means that if it is not explicitly set, in most cases it will default to the non-standard behaviour.

[GNotman]

You may also need to modify your gpios specifications above. e.g:

samermattar said:

cs-gpios = <&gpio1 7 0>;

cs-gpios = <@gpio1 7 GPIO_ACTIVE_LOW>

The irq line probably needs a similar modification as well.