Unsafe use of strncpy() in ble_ots_object_set_name()

[Nicolas Brunner]

In the nRF5 SDK, the ble_ots_object_set_name() function use strncpy() without adding a null-character to the destination.

[tesc]

Hi,

Is the issue that strncpy() will not put null termination in p_object->name if new_name (including the \0) is longer than BLE_OTS_NAME_MAX_SIZE?

Regards,
Terje

[Nicolas Brunner]

yes

[tesc]

Hi,

Great!

Thanks for the report and for the quick answer. It is highly appreciated! I have reported the issue internally to the SDK team.

Regards,
Terje