nRF9160 azure_iot_hub change DPS username during run time (continued)

[aldras]

This is a continuation of the topic here that is now closed

https://devzone.nordicsemi.com/f/nordic-q-a/85590/nrf9160-azure_iot_hub-change-dps-username-during-run-time

I have created a pull request here at the following link.

I do believe the code is not in line with standard code practices and kind of messy, but that is the basic idea and hoping something can be added similar into the azure_iot_hub library.

https://github.com/nrfconnect/sdk-nrf/pull/7195

Should I continue discussion here? or within the gitbub pull request?

As I am fairly new to github pull requests I am not sure the process required, but I believe the feature I am requesting to be added is easily understood from the uploaded pull request.

After this pull request is looked at and the required information is copied from it I would like to remove the fork from my personal git account, if this is acceptable.

Directly approving this pull request is maybe not the best idea as the code is not in line with standard coding practices, along with my personal comments in code.

Sincerely,

Allan

[Charlie]

Hi Allan,

Yes, I do think we should continue the discussion on your pull request.

My colleague Markus(coderbyheart) is the expert on this domain and will decide how the request will be processed. You can keep adding your comments there.

Best regards,

Charlie

[aldras]

Hi Charlie,

Thank you very much for the quick reply, I will continue the discussion over there on the pull request.

Allan