How to use the nrfx_spim on Zephyr 3.1?

[CacO3]

On Zephyr `2.7` I have following code to setup a SPIM on a custom board:
Device tree:

/ {
    compatible = "nordic,nrf52840-dongle-nrf52840";

    /* External ADC GPIO Pins:
     *   N_RESET_ADC: P1.09 (GPIO 33)
     *   N_DRDY_ADC : P0.24 (GPIO 5)
     *   N_CS_ADC   : P0.16 (GPIO_4)
     */
    external-adc {
        compatible = "gpio-leds"; /* why gpio-leds? */
        n_cs_adc: n_cs_adc_0 {
            gpios = <&gpio0 16 (GPIO_ACTIVE_LOW)>;
            label = "N_CS_ADC";
        };
    };
};

/* SPI Interface to ADC
 * nCS_ADC:  P0.16 GPIO_4
 * SCLK_ADC: P0.13 GPIO_1
 * DIN_ADC:  P0.14 GPIO_2
 * DOUT_ADC: P0.15 GPIO_3
 */
&spi3 {
    compatible= "nordic,nrf-spim";
    status = "okay";
    sck-pin = <13>;
    miso-pin = <15>;
    mosi-pin = <14>;
};

main.c:

/* Pin Mapping from Devicetree */
#define ADC_nSS       DT_GPIO_PIN(DT_NODELABEL(n_cs_adc), gpios)
#define ADC_SCK       NRF_GPIO_PIN_MAP(0,13) // TODO: Find a way to get pin numbers from devicetree
#define ADC_MISO      NRF_GPIO_PIN_MAP(0,15) // TODO: Find a way to get pin numbers from devicetree
#define ADC_MOSI      NRF_GPIO_PIN_MAP(0,14) // TODO: Find a way to get pin numbers from devicetree
#define ADC_nDRDY     DT_GPIO_PIN(DT_NODELABEL(n_drdy_adc), gpios)

    /* Device Handle for SPIM3 */
    static const nrfx_spim_t spi3 = NRFX_SPIM_INSTANCE(3);

    nrfx_spim_config_t spi_config;

    /* Set SPI3 properties */
    /* TODO: Find a way to use the DTS definitions for the Pin numbers */
    spi_config.ss_pin = ADC_nSS;
    spi_config.miso_pin = ADC_MISO;
    spi_config.mosi_pin = ADC_MOSI;
    spi_config.sck_pin = ADC_SCK;
 // [..]

    /* Initialize SPI Peripheral */
    if(nrfx_spim_init(&spi3, &spi_config, ads131_eventHandler, NULL)

  // [..]

Now this no longer works on Zephyr `3.1`.
I temporarily tried it with `CONFIG_PINCTRL=n` but simply do not see any data on the bus.

The correct way would be to port it to use the new `pinctrl`, but I can not find an example how to do this :(

[Simon]

I just answered a similar question here:  Which macro to get sck, mosi and miso pin on spi master 

Let me know if that answer is not sufficient

Best regards,

Simon 

[CacO3]

Dear Simon

Thank you! That helped me to migrate to pinctrl usage.

How ever I still haven't understood how to reference such a pin directly.

I have now following in my device tree:

    /* SPI Interface to ADC
     * nCS_ADC:  P0.16 GPIO_4
     * SCLK_ADC: P0.13 GPIO_1
     * DIN_ADC:  P0.14 GPIO_2
     * DOUT_ADC: P0.15 GPIO_3
     */
    spi3_default: spi3_default {
        group1 {
            psels = <NRF_PSEL(SPIM_SCK, 0, 13)>,
                <NRF_PSEL(SPIM_MISO, 0, 15)>,
                <NRF_PSEL(SPIM_MOSI, 0, 14)>;
        };
    };
&pinctrl {
    spi3_sleep: spi3_sleep {
        group1 {
            psels = <NRF_PSEL(SPIM_SCK, 0, 13)>,
                <NRF_PSEL(SPIM_MISO, 0, 15)>,
                <NRF_PSEL(SPIM_MOSI, 0, 14)>;
            low-power-enable;
        };
    };
};


&spi3 {
    compatible= "nordic,nrf-spim";
    status = "okay";
    pinctrl-0 = <&spi3_default>;
    pinctrl-1 = <&spi3_sleep>;
    pinctrl-names = "default", "sleep";
};

And in my code:

NRF_GPIO_PIN_MAP(0,13)

nrfx_spim_config_t spi_config;
spi_config.miso_pin = NRF_GPIO_PIN_MAP(0,13); // How to fetch from device tree?
[..]

[Simon]

Update 30.6.2022: Added strikethrough to incorrect statements

As I mentioned in  Which macro to get sck, mosi and miso pin on spi master, use DT_PROP_OR or DT_PROP to fetch the pins from the device tree.

For example, to fetch the miso pin from spi3, you can do the following:

#define MISO_PIN DT_PROP(DT_NODELABEL(spi3), mosi_pin)
.
.
.
spi_config.miso_pin = NRF_GPIO_PIN_MAP(0,MISO_PIN);

I haven't tested this, so please let me know if it works or not.

Best regards,

Siom

[CacO3]

Hi Simon

Thanks for your paciente!

I tried your suggestions, how ever I get following error:

zephyr/include/generated/devicetree_unfixed.h:8615:37: 
  error: 'DT_N_S_soc_S_spi_4002f000_P_mosi_pin' undeclared (first use in this function); 
  did you mean 'DT_N_S_soc_S_spi_4002f000_P_status'?

on using it as following:

#define MOSI_PIN DT_PROP(DT_NODELABEL(spi3), mosi_pin)

    spi_config.mosi_pin = NRF_GPIO_PIN_MAP(0,MOSI_PIN);

So something seems to be missing but I can't figure out what 

[Simon]

I'll look into this tomorrow.

Best regards,

Simon