We use spi flash with custom driver and goal is to set it to act as secondary partition for MCUBoot.
The question is how to adapt driver to be accepted by MCUBoot, maybe there is an example on how driver should look like?
As far as I understand Nordic supports mx25r64, what files have to be produced and where to place them to enable custom driver to be accepted by MCUBoot?
The nRF91 DK which contains an mx25r64, and it will use the spi nor driver to communicate with it:
https://github.com/nrfconnect/sdk-zephyr/blob/v3.0.99-ncs1/drivers/flash/spi_nor.c#L10
As you can see, the spi_nor.c is located inside zephyr/drivers/flash. If you do it this way, you will be able to write/read to the spi flash using the flash API.
After adding your spi flash driver and adding your flash device to the device tree you can put the secondary partition in your external flash by doing the following:
Best regards,
Simon
Thank you for clarification, Simon.
At the moment I am struggling with this error: "zephyr\include\generated\devicetree_unfixed.h:6002:34: error: 'DT_N_S_soc_S_spi_40023000_S_at25xe081_0_P_size' undeclared here (not in a function); did you mean 'DT_N_S_soc_S_spi_40023000_S_at25xe081_0_P_reg".
I added this to my_board.dts file:
&spi2 {
status = "okay";
at25xe081: at25xe081@0 {
compatible = "at25xe081";
reg = <0>;
label = "AT25XE081";
size = <67108864>;
};
};And in my driver wrapper I added #define DT_DRV_COMPAT at25xe081. However it seems that size property is not found when I am doing: flash_size = DT_INST_PROP(0, size) / 8. What I am missing here?
I could not see that at25xe081 is defined in a yaml file, which needs to be done in order to use it in a dts/overlay file.
For example "jedec,spi-nor", which is used in zephyr/boards/arm/nrf9160dk_nrf9160/nrf9160dk_nrf9160_common_0_14_0.dtsi, is defined in the yaml file https://github.com/nrfconnect/sdk-zephyr/blob/v3.0.99-ncs1/dts/bindings/mtd/jedec%2Cspi-nor.yaml + the included files: https://github.com/nrfconnect/sdk-zephyr/blob/v3.0.99-ncs1/dts/bindings/mtd/jedec%2Cspi-nor.yaml#L12
Please create new a yaml file for at25xe081.
If it's too much work, and too many abstraction layers to add the driver to Zephyr, you could probably add it directly to your application, and maybe add it to Zephyr at a later point.
You may find these DevZone cases useful:
Best regards,
Simon
I created at25xe081.yaml with the following content:
description: |
AT25XE081 serial flash.
compatible: "at25xe081"
include: spi-device.yaml
properties:
size:
type: int
required: false
description: flash capacity in bitsAnd placed it in the same folder of project files, where my_board.dts resides. But still get the same error.
Also I tried to modify my_board.yaml and added include of the new file, but it did not change anything.
At the end it is important that MCUBoot builds using the new driver and I am not sure where to place files in order to accomplish that. Can these files be part of project or I have to modify SDK folder (that we want to avoid if possible).
mesh777 said:And placed it in the same folder of project files, where my_board.dts resides. But still get the same error.
Also I tried to modify my_board.yaml and added include of the new file, but it did not change anything.
Try placing it in the same folder as jedec,spi-nor.yaml, the folder zephyr/dts/bindings/mtd.
This section may be useful to learn more about compatible/bindings: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.0.2/zephyr/build/dts/bindings.html
mesh777 said:At the end it is important that MCUBoot builds using the new driver and I am not sure where to place files in order to accomplish that. Can these files be part of project or I have to modify SDK folder (that we want to avoid if possible).
I'm not sure how to add a dts bindings out of tree. However, adding it directly to Zephyr might not be a bad idea, then you could create a Pull Request at the end, making your driver a part of Zephyr upstream (and Nordic Zephyr downstream). If this is not preferable, let me know, and I can look into do this out-of-tree.
If this is not preferable, let me know, and I can look into do this out-of-tree.
Many thanks for fast response.
Yes, I think it would be better to have out-of-tree solution.
Try adding the binding to your board folder like it's done here (<board>/dts/bindings): https://github.com/nrfconnect/sdk-nrf/tree/v2.0.2/boards/arm/thingy91_nrf9160/dts/bindings.
Regarding adding your driver out-of-tree, I'm not sure if it will work by simply following this approach: https://github.com/nrfconnect/sdk-zephyr/tree/v3.0.99-ncs1/samples/application_development/out_of_tree_driver, since your driver should not be used directly, but rather through the flash.h API. The other flash drivers are put in https://github.com/nrfconnect/sdk-zephyr/tree/v3.0.99-ncs1/drivers/flash.
I'll ask internally tomorrow how to go about this.
I realized that it might be possible that the spi_nor driver actually supports the at25xe081, I'll look into this as well.
Try adding the binding to your board folder like it's done here (<board>/dts/bindings): https://github.com/nrfconnect/sdk-nrf/tree/v2.0.2/boards/arm/thingy91_nrf9160/dts/bindings.
Regarding adding your driver out-of-tree, I'm not sure if it will work by simply following this approach: https://github.com/nrfconnect/sdk-zephyr/tree/v3.0.99-ncs1/samples/application_development/out_of_tree_driver, since your driver should not be used directly, but rather through the flash.h API. The other flash drivers are put in https://github.com/nrfconnect/sdk-zephyr/tree/v3.0.99-ncs1/drivers/flash.
I'll ask internally tomorrow how to go about this.
I realized that it might be possible that the spi_nor driver actually supports the at25xe081, I'll look into this as well.
Is it possible to run debugger in bootloader (using VS Code) ?
I managed to build the project, however get the following error from the bootloader:
*** Booting Zephyr OS build v2.7.0-ncs1 *** 00> I: Starting bootloader 00> W: Failed reading sectors; BOOT_MAX_IMG_SECTORS=128 - too small? 00> E: ***** MPU FAULT ***** 00> E: Instruction Access Violation 00> E: r0/a1: 0x00000000 r1/a2: 0x00000000 r2/a3: 0x20000284 00> E: r3/a4: 0x00000020 r12/ip: 0xe6f7fbb5 r14/lr: 0x00000e4f 00> E: xpsr: 0x61000000 00> E: Faulting instruction address (r15/pc): 0xe6f7fbb4 00> E: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0 00> E: Current thread: 0x20000128 (unknown) 00> E: Resetting system
And this is my pm_static.yml:
external_flash:
address: 0x0
region: external_flash
size: 0x800000
app:
address: 0xc200
end_address: 0x6DC80
region: flash_primary
size: 0x61A80
mcuboot:
address: 0x0
end_address: 0xc000
placement:
before:
- mcuboot_primary
region: flash_primary
size: 0xc000
mcuboot_pad:
address: 0xc000
end_address: 0xc200
placement:
align:
start: 0x1000
before:
- mcuboot_primary_app
region: flash_primary
size: 0x200
mcuboot_primary:
address: 0xc000
end_address: 0x6DC80
orig_span: &id001
- mcuboot_pad
- app
region: flash_primary
sharers: 0x1
size: 0x6DE80
span: *id001
mcuboot_primary_app:
address: 0xc200
end_address: 0x6DC80
orig_span: &id002
- app
region: flash_primary
size: 0x61A80
span: *id002
mcuboot_secondary:
address: 0x0
device: at25xe081
end_address: 0x6DE80
region: external_flash
size: 0x6DE80
settings_storage:
address: 0x7e000
end_address: 0x80000
placement:
before:
- end
region: flash_primary
size: 0x2000
sram_primary:
address: 0x20000000
end_address: 0x20010000
region: sram_primary
size: 0x10000I just talked to a colleague familiar with this stuff, and asked if at25xe081 was supported by the spi_nor driver. He said as far as he knew, most of the NOR chips should be supported by the spi_nor driver, and most of the commands from the data sheets seems to be generic, so it should not be a problem as far as he knew.
To get more details, and a more certain answer, try to ask the Zephyr experts on Zephyr Discord, if at25xe081 is supported by the spi_nor driver (Maybe add a link to the data sheet). If that is the case, you may save a lot of time.
Best regards,
Simon
mesh777 said:Maybe you can also provide a hint on how to debug the bootloader?
Ah, yes. Of course. If you debug through VS Code GDB it should be quite straightforward. See the following video: https://youtu.be/MGsZJpdLtco?list=PLx_tBuQ_KSqEt7NK-H7Lu78lT2OijwIMl&t=30
Then set a break point in <ncs location>/bootloader/mcuboot/boot/zephyr/main.c-->main() and you can start to debug.
Let me know if you don't get it to work.
I use VS Code and GDB.
Can you share working launch.json, as I am not able to manage to reach that breakpoint.
EDIT: I enabled debugging by unchecking Debug Options in build configuration.
Now I have problem with device_get_binding, it returns Null for my driver. Although MCUBoot uses the same dts file when building. What else could be possibly wrong?