We use spi flash with custom driver and goal is to set it to act as secondary partition for MCUBoot.
The question is how to adapt driver to be accepted by MCUBoot, maybe there is an example on how driver should look like?
As far as I understand Nordic supports mx25r64, what files have to be produced and where to place them to enable custom driver to be accepted by MCUBoot?
The nRF91 DK which contains an mx25r64, and it will use the spi nor driver to communicate with it:
https://github.com/nrfconnect/sdk-zephyr/blob/v3.0.99-ncs1/drivers/flash/spi_nor.c#L10
As you can see, the spi_nor.c is located inside zephyr/drivers/flash. If you do it this way, you will be able to write/read to the spi flash using the flash API.
After adding your spi flash driver and adding your flash device to the device tree you can put the secondary partition in your external flash by doing the following:
Best regards,
Simon
Thank you for clarification, Simon.
At the moment I am struggling with this error: "zephyr\include\generated\devicetree_unfixed.h:6002:34: error: 'DT_N_S_soc_S_spi_40023000_S_at25xe081_0_P_size' undeclared here (not in a function); did you mean 'DT_N_S_soc_S_spi_40023000_S_at25xe081_0_P_reg".
I added this to my_board.dts file:
&spi2 {
status = "okay";
at25xe081: at25xe081@0 {
compatible = "at25xe081";
reg = <0>;
label = "AT25XE081";
size = <67108864>;
};
};
And in my driver wrapper I added #define DT_DRV_COMPAT at25xe081. However it seems that size property is not found when I am doing: flash_size = DT_INST_PROP(0, size) / 8. What I am missing here?
mesh777 said:Now I have problem with device_get_binding, it returns Null for my driver. Although MCUBoot uses the same dts file when building. What else could be possibly wrong?
There may be different reasons for the failure of device_get_binding(). I can see in the overlay you provider earlier that label="AT25XE081", so maybe you could start by putting a break point in mcuboot when device_get_binding() is called and check that it evaluates to device_get_binding("AT25XE081").
Maybe also check the file build/mcuboot/zephyr/zephyr.dts (notice that this is a different path than build/zephyr/zephyr.dts), and check if you find the at25x node, and that it is enabled. If not, you probably need to enable it following the approaches explained in https://developer.nordicsemi.com/nRF_Connect_SDK/doc/1.9.1/nrf/ug_multi_image.html#image-specific-variables.
If the init function of you driver fails (the function that is passed into DEVICE_DT_INST_DEFINE, like done here), the call to device_get_binding will also fail.
In this reply I give some detailed explanations about why init function need to be successful for device_get_binding() to succeed, if you're interested. It may be a bit outdated due to an older NCS version.
Best regards,
Simon
I checked build/mcuboot/zephyr/zephyr.dts, at25x appears in spi2 node. Also device_get_binding is called with correct label.
However init function is not called. In driver file the following macro is added at the end of file:
mesh777 said:However init function is not called. In driver file the following macro is added at the end of file:
If your custom init function is not called, maybe it is because the custom driver file is not seen by the build system and added to the executable? Have you modified the CMakeLists.txt to include the source file? Like done for spi_nor.c for example here: https://github.com/nrfconnect/sdk-zephyr/blob/v2.7.0-ncs1/drivers/flash/CMakeLists.txt#L6 (try adding your driver in-tree first, just to make sure it works). You can check that the source file is included by looking in /<sample>/build/mcuboot/zephyr/drivers/flash/CMakeFiles/drivers__flash.dir I think (or just open build folder in vscode, click ctrl+P and search for the source (.c) file).
Again, I do think the spi_nor.c driver might support the at25x, at least it's worth checking out.
mesh777 said:And spi_flash_init is not called. What I am still missing?
Where did you find this function? I search through the whole NCS v1.8.0 (based on earlier logs, it seems like you're using this version).
This is my own static function which resides in the driver.
I need to make it out-of-tree anyway, could you please check how to proceed with that.
Thank you again.
mesh777 said:I need to make it out-of-tree anyway, could you please check how to proceed with that.
Yes, of course I can look into that. I'll do it tomorrow.
However, I think it is smart to try to resolve one issue at the time. So I would recommend this approach:
mesh777 said:I need to make it out-of-tree anyway, could you please check how to proceed with that.
Yes, of course I can look into that. I'll do it tomorrow.
However, I think it is smart to try to resolve one issue at the time. So I would recommend this approach:
mesh777 said:I need to make it out-of-tree anyway, could you please check how to proceed with that.
I talked to the developer of the out-of-tree-driver examples and got some hints on how to go about this.
Also, the developer I talked to said that it may be simpler to just maintan a fork of NCS/nrf that has just that driver, instead of making it out-of-tree.
Best regards,
Simon
Thanks a lot for detailed information. I managed to make that driver is found and init function is called.
I have some more questions:
Where to put/how to reference at25xe081.yaml in the module? At the moment I have same problem as before that dts property is not found.
How to include files to the module from the project? I have shared files between module and application (driver itself is used by application and the wrapper inside the module). So module has to find source file and header files which belong to project tree.
mesh777 said:Where to put/how to reference at25xe081.yaml in the module? At the moment I have same problem as before that dts property is not found.
Did it not work putting it in the board folder like I suggested earlier?
You can also try setting it like this: https://github.com/nrfconnect/sdk-nrf/blob/v2.0.2/samples/nrf9160/lwm2m_client/dts/bindings/pwm-buzzer.yaml
mesh777 said:How to include files to the module from the project?
Let's say that you're including drivers/spi.h, like it's done in the spi_nor.c driver https://github.com/nrfconnect/sdk-zephyr/blob/v3.0.99-ncs1/drivers/flash/spi_nor.c#L14.
Then you need to make sure that the application that is using your module (mcuboot application in your case) has set CONFIG_SPI=y. This can be done by setting CONFIG_SPI in <ncs>/bootloader/mcuboot/boot/zephyr/prj.conf (or through the main application using the approaches in this ticket).
It might be smart to do something like this:
https://github.com/nrfconnect/sdk-zephyr/blob/v3.0.99-ncs1/drivers/flash/Kconfig.nor#L6-L9
Make it select or make it depend on the necessary dependencies. So in the above case, and error will be thrown if CONFIG_SPI is not enabled.
For the out of tree driver example, it has defined a new Kconfig here: https://github.com/nrfconnect/sdk-zephyr/blob/v3.0.99-ncs1/samples/application_development/out_of_tree_driver/hello_world_module/zephyr/Kconfig#L4
You can do the same four your out of tree driver, and call it "config SPI_FLASH_AT25" for example. Then you can modfiy the Kconfig file and make it depend on SPI, like below for example
menuconfig SPI_FLASH_AT25
bool "AT25 family flash driver"
select <something>
.
.
depends on SPI
help
text text text
It's probably smart to do something like this as well: https://github.com/nrfconnect/sdk-zephyr/blob/v3.0.99-ncs1/samples/application_development/out_of_tree_driver/hello_world_module/zephyr/CMakeLists.txt#L3. So you're forced to set CONFIG_SPI_FLASH_AT25 in <ncs>/bootloader/mcuboot/boot/zephyr/prj.conf (or through the main application using the approaches in this ticket) in order to use the spi flash driver.
Best regards,
Simon
By the way, I will be gone until next Monday, so I won't be able to answer until then.
Simon