invalid suffix "_FULL_NAME" on integer constant

[elektron314]

I'm trying to implement my own driver for our custm made board based onnRF5340-QKAA. Driver is for NCT218 I2C temperature sensor.

I'm implementing it based on the samples in the Zephyr project. I described api and trying to compile but during building it shows me error like below.

/Users/el314biig/biig-fw-ws/biig-fw/NCT218-driver/tmp_nct218.c: At top level:
/Users/el314biig/biig-fw-ws/biig-fw/build/zephyr/include/generated/devicetree_generated.h:15994:49: error: invalid suffix "_FULL_NAME" on integer constant
15994 | #define DT_FOREACH_OKAY_INST_onnn_nct218(fn) fn(0)

I am super newbie in programming especially Zephyr. I don't understand where to dig in. Can anybody help me? I can send any part  of code or even the whole project.

[Einarh]

Hello

I'd be interested to see any files you've defined for your driver; KConfig, dts, overlay, yaml etc

Also the generated devicetree in build/zephyr/zephyr.dts

Best regards,

Einar

[elektron314]

Ok, here you go.Compress.zip

[Einarh]

elektron314 said:

Yes, it's compilable without my driver. It's even compilable if I delete below line from the tmp_nct218.c file

#define DT_DRV_COMPAT onnn_nct218

Have you read through this?:

https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/zephyr/build/dts/howtos.html#option-1-create-devices-using-instance-numbers

[Einarh]

Comparing to another device driver sample, maybe you're supposed to use SENSOR_DEVICE_DT_INST_DEFINE where you use SENSOR_DEVICE_DT_DEFINE in the end of tmp_nct218.c?

-Einar

[elektron314]

Yes, I read it.
Does it mean that If I exclude this #define my driver will be ignored?

[elektron314]

Now the error about fn(0) is absent and there is no any indication of special error, only the overall conclusion in the end:

collect2: error: ld returned 1 exit status

ninja: build stopped: subcommand failed.

FATAL ERROR: command exited with status 1: /usr/local/bin/cmake --build /Users/el314biig/biig-fw-ws/biig-fw/build


Can you explain the difference between those two and why it doesn't point to any special error in the building?

[Einarh]

If you're able to build it and your sensor appears in your devicetree it should be good.

You can check that you're able to access it from the devicetree by running your nct218_init function.

elektron314 said:

Does it mean that If I exclude this #define my driver will be ignored?

I don't think you necessarily have to include it, but if you want to use the driver in the same way as the drivers you've copied you'll have to include it.

There's also option 2 in the documentation I linked.

elektron314 said:

Can you explain the difference between those two and why it doesn't point to any special error in the building?

Hard to say without more context.

Are you sure there aren't any more specific errors in your build log?

-Einar

[elektron314]

It's buildable only with one exception:

I need to change overlay file

from this

compatible = "onnn,nct218";

to this

compatible = "i2c-device";

In VSC it squiggles my onnn,nct218 and says that Unknown node type. Why? What am I doing wrong?

It's located in  CMAKE_CURRENT_SOURCE_DIR/dts/bindings/sensor/onnn,nct218.yaml

[elektron314]

aha, CONFIG_SENSOR=y was needed as well. After that onnn,nct218 became understandable to the compiler