Bug in version_app.cmake

[Rait]

Hi,

There is a bug in ncs\v2.7.99-cs2\nrf\cmake\version_app.cmake

add_custom_command(
OUTPUT ${PROJECT_BINARY_DIR}/include/generated/app_commit.h
COMMAND ${CMAKE_COMMAND} -DZEPHYR_BASE=${ZEPHYR_BASE} -DNRF_DIR=${NRF_DIR}
-DOUT_FILE=${PROJECT_BINARY_DIR}/include/generated/app_commit.h
-DCOMMIT_TYPE=APP
-DCOMMIT_PATH=${CMAKE_SOURCE_DIR}
-P ${ZEPHYR_NRF_MODULE_DIR}/cmake/gen_commit_h.cmake
DEPENDS ${CMAKE_SOURCE_DIR}/VERSION ${APP_GIT_INDEX}
)

DEPENDS ${CMAKE_SOURCE_DIR}/VERSION ${APP_GIT_INDEX}

should be

DEPENDS ${APPLICATION_SOURCE_DIR}/VERSION ${APP_GIT_INDEX}

[Vidar Berg]

Hi,

Thanks for reporting this. However, I tried testing this with the peripheral_lbs sample from 'v2.7.99-cs2' but was unable to find out any issues with this implementation. Isn't ${CMAKE_SOURCE_DIR} and ${APPLICATION_SOURCE_DIR} the same in your case?

I made a copy of the SDK sample, placed it in another location outside of the SDK, and made an initial commit.

Best regards,

Vidar

[Rait]

Hi, thanks for the reply.

No, CMAKE_SOURCE_DIR and APPLICATION_SOURCE_DIR are not the same as we are using a more advanced build compared to your toy examples that do not facilitate reuse. As far as I understand there is no requirement for them to be equal and things worked just fine before SDK 2.7. Zephyr's versioning script uses APPLICATION_SOURCE_DIR as expected.

Cheers,

Rait

[Vidar Berg]

I see. I will raise a bug ticket internally. Thank you for making us aware of this.

Cheers,

Vidar

[Vidar Berg]

This will be fixed in SDK v2.8.0: https://github.com/nrfconnect/sdk-nrf/pull/18071