Potential bug in nrf_cli.c (SDK 15.3.0)

[Keith Brafford]

I am trying to light-switch test different features in my app to see if I can save some memory, and I found that the examples\peripheral\cli example won't compile if I turn off NRF_CLI_HISTORY_ENABLED

To get it to work correctly (I think) I had to add the preprocessor gating on the call to history_mode_exit() in file components\libraries\cli\nrf_cli.c, around line 1994:

#if NRF_MODULE_ENABLED(NRF_CLI_HISTORY)
history_mode_exit(p_cli);
#endif

Does this look like the right way to solve the issue?

[tesc]

Hi,

Thank you for reporting the issue of linker error when disabling CLI history mode. It is highly appreciated! I have reproduced and filed an internal issue report.

Your proposed way of solving the issue is in line with how the CLI history module is handled throughout the rest of the file.

Regards,
Terje

[Keith Brafford]

FYI the bug is still in sdk 16.0.0

[tesc]

Hi,

Your proposed fix has been added to our internal development branch of the SDK, and will be part of next nRF5 SDK release. For existing SDK releases you must add the fix yourself.

Regards,
Terje