This post is older than 2 years and might not be relevant anymore
More Info: Consider searching for newer posts

UART on nrf9160dk

Hello,

I am using UART1 to communicate with sensor. It is working fine. I can receive the data. Now I want to modify this data. When I use strcpy() function, it works properly. But when I use functions like strchr(), there is error. I will paste the code and error as well.

To modify the received data from sensor, I am modifying the UART callback function. So is this the reason for the error and what should I do to overcome this problem?

Code:

Fullscreen

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
#include <zephyr.h>
#include <misc/printk.h>
#include <uart.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
static u8_t uart_buf[1024];
void uart_cb(struct device *x)
{
    uart_irq_update(x);
    int data_length = 0;
    if (uart_irq_rx_ready(x)) {
        data_length = uart_fifo_read(x, uart_buf, sizeof(uart_buf));
        uart_buf[data_length] = 0;
    }
    printk("%s", uart_buf);
   //     k_sleep(1000);
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

#include <zephyr.h>
#include <misc/printk.h>
#include <uart.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>

static u8_t uart_buf[1024];

void uart_cb(struct device *x)
{
	uart_irq_update(x);
	int data_length = 0;

	if (uart_irq_rx_ready(x)) {
		data_length = uart_fifo_read(x, uart_buf, sizeof(uart_buf));
		uart_buf[data_length] = 0;
	}

	printk("%s", uart_buf);
   //     k_sleep(1000);
        char dest[strlen(uart_buf)];
   //     strncpy(dest,uart_buf,strlen(uart_buf));
        strcpy(dest, uart_buf);
        printk("%s", dest);
        const char ch = ',';
         char *ret;

         ret = strchr(uart_buf, ch);
         printk("%s", ret);

}

void main(void)
{
        
	struct device *uart = device_get_binding("UART_1");

	uart_irq_callback_set(uart, uart_cb);
	uart_irq_rx_enable(uart);
	printk("UART loopback start!\n");
	while (1) {
		k_cpu_idle();
                
	}
}

Output:

Fullscreen

1
2
3
4
5
6
7
8
9
10
11
UART loopback start!
$Exception occurred in Secure State
***** HARD FAULT *****
  Fault escalation (see below)
***** BUS FAULT *****
  Precise data bus error
  BFAR Address: 0x50008120
***** Hardware exception *****
Current thread ID = 0x200200b0
Faulting instruction address = 0xe608
Fatal fault in ISR! Spinning...
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

UART loopback start!
$Exception occurred in Secure State
***** HARD FAULT *****
  Fault escalation (see below)
***** BUS FAULT *****
  Precise data bus error
  BFAR Address: 0x50008120
***** Hardware exception *****
Current thread ID = 0x200200b0
Faulting instruction address = 0xe608
Fatal fault in ISR! Spinning...

Top Replies

Sigurd over 5 years ago +1

Hi, This seems to work fine when I test here: main.c #include <zephyr.h> #include <misc/printk.h> #include <uart.h> #include <stdio.h> #include <string.h> #include <stdlib.h> #define UART_BUF_SIZE…

Parents

0 Sigurd over 5 years ago

Hi,

This seems to work fine when I test here:

main.c

Fullscreen

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
#include <zephyr.h>
#include <misc/printk.h>
#include <uart.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#define UART_BUF_SIZE 1024
void uart_cb(struct device *uart)
{
    static u8_t data_array[UART_BUF_SIZE];
    static u8_t index = 0;
    
    uart_irq_update(uart);
    
    if (uart_irq_rx_ready(uart)) {
        
        int data_length;
        data_length = uart_fifo_read(uart, &data_array[index],
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

#include <zephyr.h>
#include <misc/printk.h>
#include <uart.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>

#define UART_BUF_SIZE 1024

void uart_cb(struct device *uart)
{
	static u8_t data_array[UART_BUF_SIZE];
    static u8_t index = 0;
	
	uart_irq_update(uart);
	
	if (uart_irq_rx_ready(uart)) {
		
		int data_length;

		data_length = uart_fifo_read(uart, &data_array[index],
					     UART_BUF_SIZE-index);
		index += data_length;
		

		if (index > 0) {
			
			if ((index == UART_BUF_SIZE) ||
			   (data_array[index - 1] == '\n') ||
			   (data_array[index - 1] == '\r')) {
				//printk("index: %d \n",index);
				printk("%s", data_array);
				
				char dest[strlen(data_array)];
				strcpy(dest, data_array);
				printk("%s", dest);
				const char ch = ',';
				char *ret;
				ret = strchr(data_array, ch);
				
				if(ret != NULL){
				printk("%s", ret);
				}

				index = 0;
				memset(data_array, 0, sizeof(data_array));
			}
		}
	}

}

void main(void)
{
        
	struct device *uart = device_get_binding("UART_1");

	uart_irq_callback_set(uart, uart_cb);
	uart_irq_rx_enable(uart);
	printk("UART sample start!\n");
	while (1) {
		k_cpu_idle();
                
	}
}

prj.conf

Fullscreen

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
#
# Copyright (c) 2019 Nordic Semiconductor ASA
#
# SPDX-License-Identifier: LicenseRef-BSD-5-Clause-Nordic
#
# General config
#CONFIG_NEWLIB_LIBC=y
CONFIG_ASSERT=y
CONFIG_TEST_RANDOM_GENERATOR=y
CONFIG_REBOOT=y
# Network
CONFIG_NETWORKING=y
CONFIG_NET_NATIVE=n
CONFIG_NET_SOCKETS=y
CONFIG_NET_SOCKETS_OFFLOAD=y
# BSD library
CONFIG_BSD_LIBRARY=y
# Stacks and heaps
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

#
# Copyright (c) 2019 Nordic Semiconductor ASA
#
# SPDX-License-Identifier: LicenseRef-BSD-5-Clause-Nordic
#
# General config
#CONFIG_NEWLIB_LIBC=y
CONFIG_ASSERT=y
CONFIG_TEST_RANDOM_GENERATOR=y
CONFIG_REBOOT=y

# Network
CONFIG_NETWORKING=y
CONFIG_NET_NATIVE=n
CONFIG_NET_SOCKETS=y
CONFIG_NET_SOCKETS_OFFLOAD=y

# BSD library
CONFIG_BSD_LIBRARY=y

# Stacks and heaps
CONFIG_MAIN_STACK_SIZE=8192
CONFIG_HEAP_MEM_POOL_SIZE=16384



CONFIG_UART_1_NRF_UARTE=y
CONFIG_UART_1_NRF_FLOW_CONTROL=y
CONFIG_UART_INTERRUPT_DRIVEN=y

nrf9160_pca10090ns.overlay

Fullscreen

1
2
3
4
5
6
7
8
&uart1 {
    current-speed = <115200>;
    status = "okay";
    tx-pin = <1>;
    rx-pin = <0>;
    rts-pin = <14>;
    cts-pin = <15>;
};
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

&uart1 {
	current-speed = <115200>;
	status = "okay";
	tx-pin = <1>;
	rx-pin = <0>;
	rts-pin = <14>;
	cts-pin = <15>;
};

Building and flashing with:

Fullscreen

1
west build -b nrf9160_pca10090ns -d my_build_folder -p && west flash -d my_build_folder
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

west build -b nrf9160_pca10090ns -d my_build_folder -p && west flash -d my_build_folder

with nrfjprog -v

Fullscreen

1
2
3
C:\ncs\nrf\samples\nrf9160\uart>nrfjprog -v
nrfjprog version: 10.5.0
JLinkARM.dll version: 6.54c
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

C:\ncs\nrf\samples\nrf9160\uart>nrfjprog -v
nrfjprog version: 10.5.0
JLinkARM.dll version: 6.54c

If this does not work for you, let me know what NCS tag/commit/branch you are using.

0 Jagruti over 5 years ago in reply to Sigurd

Hello,

Thank you very much for the reply. The code you sent is working.

Actually I am trying to separate the GNSS data received by UART. Now I can separte the data once then the hard fault comes. What is the condition to be set so that the hard fault doesn't come and I can separate the data continuously?

Code:

Fullscreen

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
#include <zephyr.h>
#include <misc/printk.h>
#include <uart.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#define UART_BUF_SIZE 1024
#define FIND_AND_NUL(s, p, c) ( \
   (p) = strchr(s, c), \
   *(p) = '\0', \
   ++(p), \
   (p))
void uart_cb(struct device *uart)
{
    static u8_t data_array[UART_BUF_SIZE];
    static u8_t index = 0;
    
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

#include <zephyr.h>
#include <misc/printk.h>
#include <uart.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>

#define UART_BUF_SIZE 1024

#define FIND_AND_NUL(s, p, c) ( \
   (p) = strchr(s, c), \
   *(p) = '\0', \
   ++(p), \
   (p))


void uart_cb(struct device *uart)
{
    static u8_t data_array[UART_BUF_SIZE];
    static u8_t index = 0;
	
	uart_irq_update(uart);
	
	if (uart_irq_rx_ready(uart)) {
		
		int data_length;

		data_length = uart_fifo_read(uart, &data_array[index],
					     UART_BUF_SIZE-index);
		index += data_length;
		

		if (index > 0) {
			
			if ((index == UART_BUF_SIZE) ||
			   (data_array[index - 1] == '\n') ||
			   (data_array[index - 1] == '\r')) {
				//printk("index: %d \n",index);
				printk("%s", data_array);
				
//				char dest[strlen(data_array)];
//				strcpy(dest, data_array);
//				printk("%s", dest);
				
//              const char ch = ',';
//				char *ret;
//				ret = strchr(data_array, ch);
//				if(ret != NULL){
//				printk("%s", ret);
//				}
                                
                                char* Message_id = data_array;
                                char* Time = FIND_AND_NUL(data_array, Time, ',');
                                char* Data_Valid =FIND_AND_NUL(Time, Data_Valid, ',');
                                char* Raw_Latitude = FIND_AND_NUL(Data_Valid, Raw_Latitude, ',');
                                char* N_S = FIND_AND_NUL(Raw_Latitude, N_S, ',');
                                char* Raw_Longitude = FIND_AND_NUL(N_S, Raw_Longitude, ',');
                                char* E_W = FIND_AND_NUL(Raw_Longitude, E_W, ',');
                                char* Speed = FIND_AND_NUL(E_W, Speed, ',');
                                char* COG = FIND_AND_NUL(Speed, COG, ',');
                                char* Date = FIND_AND_NUL(COG, Date, ',');
                                char* Magnetic_Variation = FIND_AND_NUL(Date, Magnetic_Variation, ',');
                                char* M_E_W = FIND_AND_NUL(Magnetic_Variation, M_E_W, ',');
                                char* Checksum = FIND_AND_NUL(M_E_W, Checksum, ',');

                                printk("The Message ID is : %s\n", Message_id);
                                printk("The Time is : %s\n", Time);                              
                                printk("The data valid is : %s\n", Data_Valid);
                                printk("The Latitude is : %s\n", Raw_Latitude);
                                printk("The N_S is : %s\n", N_S);
                                printk("The Longitude is : %s\n", Raw_Longitude);
                                printk("The E_W is : %s\n", E_W);
                                printk("The Speed is : %s\n", Speed);
                                printk("The COG is : %s\n", COG);
                                printk("The Date is : %s\n", Date);
                                printk("The Magnetic_Variation is : %s\n", Magnetic_Variation);
                                printk("The M_E_W is : %s\n", M_E_W);
                                printk("The Checksum is : %s\n", Checksum);
				
				index = 0;
				memset(data_array, 0, sizeof(data_array));
			}
		}
	}

}

void main(void)
{
        
	struct device *uart = device_get_binding("UART_1");

	uart_irq_callback_set(uart, uart_cb);
	uart_irq_rx_enable(uart);
	printk("UART sample start!\n");
	while (1) {
		k_cpu_idle();

		}
}

Output:

Fullscreen

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
UART sample start!
The Message ID is : $GPRMC
The Time is : 132920.077
The data valid is : V
The Latitude is : 
The N_S is : 
The Longitude is : 
The E_W is : 
The Speed is : 0.00
The COG is : 0.00
The Date is : 191119
The Magnetic_Variation is : 
The M_E_W is : 
The Checksum is : N*46
Exception occurred in Secure State
***** HARD FAULT *****
  Fault escalation (see below)
***** BUS FAULT *****
  Precise data bus error
  BFAR Address: 0x50008120
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

UART sample start!
The Message ID is : $GPRMC
The Time is : 132920.077
The data valid is : V
The Latitude is : 
The N_S is : 
The Longitude is : 
The E_W is : 
The Speed is : 0.00
The COG is : 0.00
The Date is : 191119
The Magnetic_Variation is : 
The M_E_W is : 
The Checksum is : N*46

Exception occurred in Secure State
***** HARD FAULT *****
  Fault escalation (see below)
***** BUS FAULT *****
  Precise data bus error
  BFAR Address: 0x50008120
***** Hardware exception *****
Current thread ID = 0x200200b0
Faulting instruction address = 0xc538
Fatal fault in ISR! Spinning...

Reply

0 Jagruti over 5 years ago in reply to Sigurd

Hello,

Thank you very much for the reply. The code you sent is working.

Code:

Fullscreen

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
#include <zephyr.h>
#include <misc/printk.h>
#include <uart.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#define UART_BUF_SIZE 1024
#define FIND_AND_NUL(s, p, c) ( \
   (p) = strchr(s, c), \
   *(p) = '\0', \
   ++(p), \
   (p))
void uart_cb(struct device *uart)
{
    static u8_t data_array[UART_BUF_SIZE];
    static u8_t index = 0;
    
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

#include <zephyr.h>
#include <misc/printk.h>
#include <uart.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>

#define UART_BUF_SIZE 1024

#define FIND_AND_NUL(s, p, c) ( \
   (p) = strchr(s, c), \
   *(p) = '\0', \
   ++(p), \
   (p))


void uart_cb(struct device *uart)
{
    static u8_t data_array[UART_BUF_SIZE];
    static u8_t index = 0;
	
	uart_irq_update(uart);
	
	if (uart_irq_rx_ready(uart)) {
		
		int data_length;

		data_length = uart_fifo_read(uart, &data_array[index],
					     UART_BUF_SIZE-index);
		index += data_length;
		

		if (index > 0) {
			
			if ((index == UART_BUF_SIZE) ||
			   (data_array[index - 1] == '\n') ||
			   (data_array[index - 1] == '\r')) {
				//printk("index: %d \n",index);
				printk("%s", data_array);
				
//				char dest[strlen(data_array)];
//				strcpy(dest, data_array);
//				printk("%s", dest);
				
//              const char ch = ',';
//				char *ret;
//				ret = strchr(data_array, ch);
//				if(ret != NULL){
//				printk("%s", ret);
//				}
                                
                                char* Message_id = data_array;
                                char* Time = FIND_AND_NUL(data_array, Time, ',');
                                char* Data_Valid =FIND_AND_NUL(Time, Data_Valid, ',');
                                char* Raw_Latitude = FIND_AND_NUL(Data_Valid, Raw_Latitude, ',');
                                char* N_S = FIND_AND_NUL(Raw_Latitude, N_S, ',');
                                char* Raw_Longitude = FIND_AND_NUL(N_S, Raw_Longitude, ',');
                                char* E_W = FIND_AND_NUL(Raw_Longitude, E_W, ',');
                                char* Speed = FIND_AND_NUL(E_W, Speed, ',');
                                char* COG = FIND_AND_NUL(Speed, COG, ',');
                                char* Date = FIND_AND_NUL(COG, Date, ',');
                                char* Magnetic_Variation = FIND_AND_NUL(Date, Magnetic_Variation, ',');
                                char* M_E_W = FIND_AND_NUL(Magnetic_Variation, M_E_W, ',');
                                char* Checksum = FIND_AND_NUL(M_E_W, Checksum, ',');

                                printk("The Message ID is : %s\n", Message_id);
                                printk("The Time is : %s\n", Time);                              
                                printk("The data valid is : %s\n", Data_Valid);
                                printk("The Latitude is : %s\n", Raw_Latitude);
                                printk("The N_S is : %s\n", N_S);
                                printk("The Longitude is : %s\n", Raw_Longitude);
                                printk("The E_W is : %s\n", E_W);
                                printk("The Speed is : %s\n", Speed);
                                printk("The COG is : %s\n", COG);
                                printk("The Date is : %s\n", Date);
                                printk("The Magnetic_Variation is : %s\n", Magnetic_Variation);
                                printk("The M_E_W is : %s\n", M_E_W);
                                printk("The Checksum is : %s\n", Checksum);
				
				index = 0;
				memset(data_array, 0, sizeof(data_array));
			}
		}
	}

}

void main(void)
{
        
	struct device *uart = device_get_binding("UART_1");

	uart_irq_callback_set(uart, uart_cb);
	uart_irq_rx_enable(uart);
	printk("UART sample start!\n");
	while (1) {
		k_cpu_idle();

		}
}

Output:

Fullscreen

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
UART sample start!
The Message ID is : $GPRMC
The Time is : 132920.077
The data valid is : V
The Latitude is : 
The N_S is : 
The Longitude is : 
The E_W is : 
The Speed is : 0.00
The COG is : 0.00
The Date is : 191119
The Magnetic_Variation is : 
The M_E_W is : 
The Checksum is : N*46
Exception occurred in Secure State
***** HARD FAULT *****
  Fault escalation (see below)
***** BUS FAULT *****
  Precise data bus error
  BFAR Address: 0x50008120
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

UART sample start!
The Message ID is : $GPRMC
The Time is : 132920.077
The data valid is : V
The Latitude is : 
The N_S is : 
The Longitude is : 
The E_W is : 
The Speed is : 0.00
The COG is : 0.00
The Date is : 191119
The Magnetic_Variation is : 
The M_E_W is : 
The Checksum is : N*46

Exception occurred in Secure State
***** HARD FAULT *****
  Fault escalation (see below)
***** BUS FAULT *****
  Precise data bus error
  BFAR Address: 0x50008120
***** Hardware exception *****
Current thread ID = 0x200200b0
Faulting instruction address = 0xc538
Fatal fault in ISR! Spinning...

Children

0 Sigurd over 5 years ago in reply to Jagruti

Hi,

How does your prj.conf file looks like? Are you using an overlay ? Are you compiling for nrf9160_pca10090ns or nrf9160_pca10090 ?
0 Jagruti over 5 years ago in reply to Sigurd
prj.conf

Fullscreen
1
2
3
4
5
6
CONFIG_SERIAL=y
CONFIG_TRUSTED_EXECUTION_NONSECURE=y
CONFIG_UART_INTERRUPT_DRIVEN=y
CONFIG_MAIN_STACK_SIZE=4096
CONFIG_UART_1_NRF_UARTE=y
CONFIG_BSD_LIBRARY_TRACE_ENABLED=n
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
CONFIG_SERIAL=y CONFIG_TRUSTED_EXECUTION_NONSECURE=y CONFIG_UART_INTERRUPT_DRIVEN=y CONFIG_MAIN_STACK_SIZE=4096 CONFIG_UART_1_NRF_UARTE=y CONFIG_BSD_LIBRARY_TRACE_ENABLED=n

nrf9160_pca10090ns.dts_compiled

Fullscreen
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
/dts-v1/;
/ {
#address-cells = < 0x01 >;
#size-cells = < 0x01 >;
model = "Nordic PCA10090 Dev Kit";
compatible = "nordic,pca10090-dk", "nordic,nrf9160-sica", "nordic,nrf9160";
uart1: uart@9000 {
compatible = "nordic,nrf-uarte";
reg = < 0x9000 0x1000 >;
interrupts = < 0x09 0x01 >;
status = "ok";
label = "UART_1";
current-speed = < 0x1c200 >;
tx-pin = < 0x01 >;
rx-pin = < 0x00 >;
rts-pin = < 0x0e >;
cts-pin = < 0x0f >;
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
/dts-v1/; / { #address-cells = < 0x01 >; #size-cells = < 0x01 >; model = "Nordic PCA10090 Dev Kit"; compatible = "nordic,pca10090-dk", "nordic,nrf9160-sica", "nordic,nrf9160"; uart1: uart@9000 { compatible = "nordic,nrf-uarte"; reg = < 0x9000 0x1000 >; interrupts = < 0x09 0x01 >; status = "ok"; label = "UART_1"; current-speed = < 0x1c200 >; tx-pin = < 0x01 >; rx-pin = < 0x00 >; rts-pin = < 0x0e >; cts-pin = < 0x0f >; };

There is no overlay file. All definitions are in dts_compiled and I am compiling for nrf9160_pca10090ns.

Your given code is working. I can receive the data continuously. when I remove if(ret != NULL) from the code, I get data once and then there is hard fault. So what is the condition to remove the hard fault from my code. I tried various things but it is not working. I get the output once then there is hard fault.