DFU_public_key.c won't compile.

[SL06]

I have create a new DFU_public_key.c file with nrf_util and replace the existing file in the dfu_req_handling folder (MacOSX).

I had to change the name of the nRF5_SDK_14.2-2.0_17b948a  to nRF5_SDK_14  because Terminal.app had problem with the name while navigating directories.

When I compile the program with the new key in place,  I have the following compiling error :

Compiling ‘dfu_public_key.c’   

expected '}' before numeric constant

to match this '{'

The error point at the second 0x....  line (line 11).

Here is the file with the key hidden:

/* This file was automatically generated by nrfutil on 2019-12-13 (YY-MM-DD) at 15:42:07 */

#include "stdint.h"
#include "compiler_abstraction.h"

/** @brief Public key used to verify DFU images */
__ALIGN(4) const uint8_t pk[64] =
{
    0x....
    0x....
};

I don't see the problem with the file.  

Help would be appreciate.   Thanks

[Edvin]

Hello,

What version of nrfutil do you use? You can check by using the command "nrfutil version".

What compiler do you use? Is it possible to send the dfu_public_key.c file (or a separate dfu_public_key.c that you don't intend to use, but can replicate the problem)?

What command did you use to generate the keys?

Can you try with the attached dfu_public_key.c? Does that compile?

Fullscreen dfu_public_key.c Download

/* This file was automatically generated by nrfutil on 2019-12-16 (YY-MM-DD) at 14:00:14 */

#include "stdint.h"
#include "compiler_abstraction.h"

/** @brief Public key used to verify DFU images */
__ALIGN(4) const uint8_t pk[64] =
{
    0xfe, 0x9e, 0x34, 0x2f, 0x68, 0x35, 0x1d, 0x0a, 0x24, 0x5d, 0x7f, 0x50, 0x36, 0x67, 0xa7, 0x73, 0xb9, 0x7f, 0xbd, 0x76, 0x82, 0x9f, 0x96, 0xf1, 0x43, 0xad, 0x70, 0xf8, 0x6a, 0x24, 0x50, 0x09
    0x65, 0x5a, 0x05, 0x62, 0xf4, 0x97, 0xe0, 0x8f, 0xaa, 0xc0, 0x1a, 0x2a, 0x38, 0xdb, 0x3a, 0x43, 0x33, 0x25, 0xcb, 0xcc, 0xae, 0x94, 0xa3, 0x42, 0x3a, 0x5e, 0x4d, 0xc1, 0x3f, 0xe3, 0xe3, 0x34
};

BR,
Edvin

[Edvin]

Sorry. I checked now, and I saw the same behavior. It seems like there is a bug in the latest version of nrfutil. the dfu_public_key.c (or whatever you choose to call it) is missing a comma at the end of the first line of the key. So if you add this comma, it should compile. Taking the dfu_public_key.c that I sent you, it should look like this after the fix:

/* This file was automatically generated by nrfutil on 2019-12-16 (YY-MM-DD) at 14:00:14 */

#include "stdint.h"
#include "compiler_abstraction.h"

/** @brief Public key used to verify DFU images */
__ALIGN(4) const uint8_t pk[64] =
{
    0xfe, 0x9e, 0x34, 0x2f, 0x68, 0x35, 0x1d, 0x0a, 0x24, 0x5d, 0x7f, 0x50, 0x36, 0x67, 0xa7, 0x73, 0xb9, 0x7f, 0xbd, 0x76, 0x82, 0x9f, 0x96, 0xf1, 0x43, 0xad, 0x70, 0xf8, 0x6a, 0x24, 0x50, 0x09,
    0x65, 0x5a, 0x05, 0x62, 0xf4, 0x97, 0xe0, 0x8f, 0xaa, 0xc0, 0x1a, 0x2a, 0x38, 0xdb, 0x3a, 0x43, 0x33, 0x25, 0xcb, 0xcc, 0xae, 0x94, 0xa3, 0x42, 0x3a, 0x5e, 0x4d, 0xc1, 0x3f, 0xe3, 0xe3, 0x34
};

I will report this internally. Thank you for the feedback.

Best regards,

Edvin

[SL06]

Yes, the script work, but partially.  I have now the uECC files, but I have the following problem :

SLMini-I5-172:micro-ecc slareau$ make -C nrf51_armgcc/armgcc &&

> make -C nrf51_iar/armgcc &&

> make -C nrf51_keil/armgcc &&

> make -C nrf52hf_armgcc/armgcc &&

> make -C nrf52hf_iar/armgcc &&

> make -C nrf52hf_keil/armgcc &&

> make -C nrf52nf_armgcc/armgcc &&

> make -C nrf52nf_iar/armgcc &&

> make -C nrf52nf_keil/armgcc

make: /usr/local/gcc-arm-none-eabi-4_9-2015q3/bin/arm-none-eabi-gcc: Command not found

Cannot find: '/usr/local/gcc-arm-none-eabi-4_9-2015q3/bin/arm-none-eabi-gcc'.

Please set values in: "/Users/slareau/nrf52_development/nRF5_SDK_14/components/toolchain/gcc/Makefile.posix"

according to the actual configuration of your system.

../../../../components/toolchain/gcc/Makefile.common:129: *** Cannot continue.  Stop.

[SL06]

I have just look in the folder /usr/local and the folder gcc-arm-none-eabi-4_9-2015q3 is absent.

[SL06]

I have download and install the gcc-arm file from this site : https://launchpad.net/gcc-arm-embedded/+download  and have install the 4.9 - 2014 q4 version. although a version 5.4 was available.

I have change the

nRF5_SDK_14/components/toolchain/gcc/Makefile.posix file according to the version installed:

GNU_INSTALL_ROOT := /usr/local/gcc-arm-none-eabi-4_9-2014q4/bin/
GNU_VERSION := 4.9
GNU_PREFIX := arm-none-eabi

Then the build_all.sh work fine up to the end.

[SL06]

Finaly, the secure_dfu_ble app is compiling without error.... Thanks

[Edvin]

Hello,

Sorry for the late reply. I have been out of office for the Christmas Holidays, and we have been short staffed, so we have not been able to answer all the cases.

 

SL06 said:

and have install the 4.9 - 2014 q4 version. although a version 5.4 was available

 That is good. I recommend you to use the same version that the SDK that you are using was written in and tested with.

Best regards,

Edvin