S340 v6.1.1 advertise on coded phy?

[brett_anderson]

I'm trying to advertise on the coded phy, but SDK 16 seems to have a block in place against doing this when you use S340. I can obviously edit this, but I don't normally edit the SDK without checking first. Does the S340 fully support the coded phy?

static bool config_is_valid(ble_adv_modes_config_t const * const p_config)
{
    if ((p_config->ble_adv_directed_high_duty_enabled == true) &&
        (p_config->ble_adv_extended_enabled == true))
    {
        return false;
    }
#if !defined (S140)
    else if ( p_config->ble_adv_primary_phy == BLE_GAP_PHY_CODED ||
              p_config->ble_adv_secondary_phy == BLE_GAP_PHY_CODED)
    {
        return false;
    }
#endif // !defined (S140)
    else
    {
        return true;
    }
}

As you can see, in ble_advertising.c if you are not specified with S140, it will not init the advertising module with the coded phy.

[brett_anderson]

So, there is a second block, in ble_advertising.c, called phy_is_valid(), that also blocks unless the S140 is specified. 

Turns out, if I comment out both of these blocks, the S340 does indeed advertise using the coded phy.

So my question remains, is the coded phy fully supported or not in S340? If it is, then I will simply leave my edits in place. I assume that Nordic will want to add a further check to include the S340 for future SDK releases. If it is not fully supported, when do we expect it to be?