FDS garbage collection not clearing dirty records

[Yogeshwaran]

Hi below is the function i am using to run garbage collection after deleting the data but the result i am getting was the same as before garbage collection.

I mean DIRTY_RECORDS_BEFORE_GC = DIRTY_RECORDS_AFTER_GC.

static void delete_all() {
  NRF_LOG_INFO("deleting all records...");
  ret_code_t rc;
  bool next_record = true;
  while (next_record) {
    fds_record_desc_t record_desc = {0};
    fds_find_token_t ftok = {0};
    if (fds_record_iterate(&record_desc, &ftok) == FDS_SUCCESS) {
      ret_code_t ret = fds_record_delete(&record_desc);
      while (!fds_delete_complete)
        ;
      fds_delete_complete = false;
      //NRF_LOG_INFO("Iterate suc..");
      next_record = true;
    } else {
      next_record = false;
    }
  }
  fds_stat_t stat = {0};
  rc = fds_stat(&stat);
  APP_ERROR_CHECK(rc);
  uint16_t no_of_records = stat.valid_records;
  NRF_LOG_INFO("delete all:: %d", no_of_records);
  NRF_LOG_INFO("dirty records %d", stat.dirty_records);
  fds_gc();
  while (!fds_gc_complete);
  fds_gc_complete = false;
    rc = fds_stat(&stat);
    APP_ERROR_CHECK(rc);
    NRF_LOG_INFO("dirty records after gc %d", stat.dirty_records);
}

 

Do i need to reinitialize the fds again to get proper dirty records value?

[Vidar Berg]

Hello,

Which SDK version are you using? Early versions of the FDS had a bug that caused the record statistics to not get updated after GC if I remember correctly.

Thanks.

[Yogeshwaran]

SDK 15.3.0

[Vidar Berg]

Ok, thanks for confirming. The issue I had in mind was fixed before SDK v15.3.0 so it must be something else. A couple of follow up questions: is the 'fds_gc_complete' declared volatile and do you check that the event result is NRF_SUCCESS before you set fds_gc_complete=true ?

[Yogeshwaran]

Yes fds_gc_complete is declared as volatile and in event handler i am making it true under FDS_EVENT_GC switch case. Even i put some delay for the fds to complete its operation properly but no use.

[Vidar Berg]

But do you check the event result in the FDS_EVENT_GC case?

e.g.,

        case FDS_EVT_GC:
        {
            if (p_evt->result == NRF_SUCCESS)
            {
                fds_gc_complete=true
            }