CONFIG_PCD includes code for both application and network processors which brings unwanted dependencies

[denis]

I'm writing custom boot loaders.  One of the capabilities is to update the network processor from code running on the application processor.  The PCD subsystem looks like it has what I need to do this nicely.  However, the PCD subsystem has a single configuration option that brings in code for both the network and application processor.  Thus when using PCD on the application side the function pcd_fw_copy is compiled - even though that function is only for the network processor.  That in turn requires FLASH_PAGE_LAYOUT, STREAM_FLASH, and STREAM_ERASE.  The application code that I'm writing does not want those (unused) requirements.  It would be great if the Kconfig for PCD had two different config options.  For example, PCD_APP and PCD_NET, so that you can bring in only the code (and dependencies) needed for the application processor or the network processor.  [A PCD configuration could select both for backwards compatibility if desired.]

Is this forum the place to post such things?  If so any thoughts on this?  If not where should it be posted?

[Carl Richard]

Hi, Denis!

Thank you for reaching out. I agree that this indeed a good suggestion. Taking this through our normal development channels could take some time, so I suggest that you actually try to implement your desired changes for the Kconfig yourself. If you succeed we would appreciate if you own pull request(PR) to the NCS repository on GitHub, according to the Zephyr contribution guidelines. You will likely get some feedback from the developers on the PR as well that could help improving it further.

Best regards,
Carl Richard

[denis]

Hi Carl,

Sounds good.  Do you have up to date details on how to contribute to ncs/nrf?  I haven't done that before, so the step by step instructions are great.  However, looking at the first step of changing "origin" to "upstream" doesn't work because the remotes are "nordic" (not "origin"):

$ git remote -v

nordic github.com/.../sdk-nrf (fetch)

nordic github.com/.../sdk-nrf (push)

Should I be changing "nordic" to "upstream"?  Any other differences?

[Carl Richard]

Hi again!

We haven't updated the contribution details for NCS yet, unfortunately. However, I believe it should be enough to change "nordic" to "upstream". Comparing with my setup that's the only difference.

Best regards,
Carl Richard

[denis]

I followed the guide and submitted a pull request.  I'm seeing the following message which says they aren't accepting external contributions though.  Is that the case?

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization.
At this time we are not accepting external contributions, but this may change soon.
Please visit https://devzone.nordicsemi.com/ to raise any issues you found or ask for help.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

[Carl Richard]

Hi again!

I was under the impression that this had changed with the v1.5.0 release of NCS, but it seems like there still is a restriction. I'll have a talk with the developers to sort this out! It's not likely that there will be any update before after easter though, i.e. next Tuesday.

Anyway, thank you very much for the contribution! I'll keep you posted.

Best regards,
Carl Richard

[denis]

Looks like the change is being incorporated.  Thanks!