Add new button on nrf5340 Audio DK fail

[LandyWang]

Hello,

I want to add an extra button on nrf5340 Audio DK.

I use P1.14 as the pin of this new button and set it in the overlay file.

/ {
	buttons {
			compatible = "gpio-keys";
			button6: button_6 {
					gpios = <&gpio1 14 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;
					label = "Push button 6";
			};
	};
	aliases {
		bkey = &button6;
	};
};

The default buttons use DT_GPIO_PIN to get the pin cell value, but according to the settings in gpio.h, DT_GPIO_PIN is only used by the PIO of gpio0, not including the P1.14 I use.

So I use DT_GPIO_PIN_BY_IDX to read the pin cell value of the new button, the following is my code:

/** @brief List of buttons and associated metadata
 */
enum button_pin_names {
	BUTTON_VOLUME_DOWN = DT_GPIO_PIN(DT_ALIAS(sw0), gpios),
	BUTTON_VOLUME_UP = DT_GPIO_PIN(DT_ALIAS(sw1), gpios),
	BUTTON_PLAY_PAUSE = DT_GPIO_PIN(DT_ALIAS(sw2), gpios),
	BUTTON_4 = DT_GPIO_PIN(DT_ALIAS(sw3), gpios),
	BUTTON_5 = DT_GPIO_PIN(DT_ALIAS(sw4), gpios),
	BUTTON_6 = DT_GPIO_PIN_BY_IDX(DT_ALIAS(bkey), gpios, 1),
};

Then I get an error during building: identifier "DT_N_S_buttons_S_button_6_P_gpios_IDX_1_VAL_pin" is undefined

But if I use DT_GPIO_PIN instead or modify the idx parameter of DT_GPIO_PIN_BY_IDX to 0, the build will succeed without error.

I'm not quite sure where the problem is, if I want to use the PIO of gpio1, is there anything else I need to modify?

[Sigurd]

Hi,

You can use NRF_DT_GPIOS_TO_PSEL() instead.

BUTTON_6 = NRF_DT_GPIOS_TO_PSEL(DT_ALIAS(bkey), gpios),

https://github.com/nrfconnect/sdk-zephyr/blob/main/soc/arm/nordic_nrf/common/soc_nrf_common.h#L95

[LandyWang]

Thank you for your reply.
But it doesn't work，I get an error during building: identifier 'DT_N_S_buttons_S_button_6' undeclared here (not in a function).

[Sigurd]

Hi,

Try doing a pristine build.

It works fine here testing with NCS 2.2.0

My test sample:

3264.hello_world.zip

[LandyWang]

Hi,

I do pristine build every time, but the error still occurs.

I am using nrf5340_audio application, and my overlay file name is nrf5340_audio_dk_nrf5340_cpuapp.overlay.

I compared your test sample with my audio application, and there is no difference in the BUTTON_6 part.

[Sigurd]

Hi,

Try adding 

#include <soc.h>

to the file where you have this:

enum button_pin_names {
	BUTTON_VOLUME_DOWN = DT_GPIO_PIN(DT_ALIAS(sw0), gpios),
	BUTTON_VOLUME_UP = DT_GPIO_PIN(DT_ALIAS(sw1), gpios),
	BUTTON_PLAY_PAUSE = DT_GPIO_PIN(DT_ALIAS(sw2), gpios),
	BUTTON_4 = DT_GPIO_PIN(DT_ALIAS(sw3), gpios),
	BUTTON_5 = DT_GPIO_PIN(DT_ALIAS(sw4), gpios),
	BUTTON_6 = NRF_DT_GPIOS_TO_PSEL(DT_ALIAS(bkey), gpios),
};

[LandyWang]

Hi,

It works.Thank you very much.

But after I add BUTTON_6 to my button configure and flash to the nrf5340 audio dk board,it occurrs error:

Here is the code I add:

const static struct btn_config btn_cfg[] = {
	{
		.btn_name = STRINGIFY(BUTTON_VOLUME_DOWN),
		.btn_pin = BUTTON_VOLUME_DOWN,
		.btn_cfg_mask = DT_GPIO_FLAGS(DT_ALIAS(sw0), gpios),
	},
	{
		.btn_name = STRINGIFY(BUTTON_VOLUME_UP),
		.btn_pin = BUTTON_VOLUME_UP,
		.btn_cfg_mask = DT_GPIO_FLAGS(DT_ALIAS(sw1), gpios),
	},
	{
		.btn_name = STRINGIFY(BUTTON_PLAY_PAUSE),
		.btn_pin = BUTTON_PLAY_PAUSE,
		.btn_cfg_mask = DT_GPIO_FLAGS(DT_ALIAS(sw2), gpios),
	},
	{
		.btn_name = STRINGIFY(BUTTON_4),
		.btn_pin = BUTTON_4,
		.btn_cfg_mask = DT_GPIO_FLAGS(DT_ALIAS(sw3), gpios),
	},
	{
		.btn_name = STRINGIFY(BUTTON_5),
		.btn_pin = BUTTON_5,
		.btn_cfg_mask = DT_GPIO_FLAGS(DT_ALIAS(sw4), gpios),
	},
	{
		.btn_name = STRINGIFY(BUTTON_6),
		.btn_pin = BUTTON_6,
		.btn_cfg_mask = DT_GPIO_FLAGS(DT_ALIAS(bkey), gpios),
	}
};

How to enable this pin?

[Sigurd]

Hi,

I looked a bit more into the code. Unfortunately, it seems like the Audio application's button_handler module only supports GPIO port 0. So you either need to modify this module yourself, or wait until we add support for this.

https://github.com/nrfconnect/sdk-nrf/blob/main/applications/nrf5340_audio/src/modules/button_handler.c#L193

[LandyWang]

Hi,

I see.

Thank you for your assistance.